From: David Miller <davem@davemloft.net>
To: alistair@popple.id.au
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver
Date: Fri, 07 Mar 2014 15:41:42 -0500 (EST) [thread overview]
Message-ID: <20140307.154142.488351276799532264.davem@davemloft.net> (raw)
In-Reply-To: <1394077948-8395-3-git-send-email-alistair@popple.id.au>
From: Alistair Popple <alistair@popple.id.au>
Date: Thu, 6 Mar 2014 14:52:25 +1100
> + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN
> + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
When an expression spans multiple lines, the lines should end with
operators rather than begin with them.
Also, it would be easier to read this call if parenthesis were put
around the third argument and then indented to match, f.e.:
out_be32(dev->reg, (in_be32(dev->reg) | WKUP_ETH_RGMIIEN |
WKUP_ETH_TX_OE | WKUP_ETH_RX_IE));
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver
Date: Fri, 07 Mar 2014 15:41:42 -0500 (EST) [thread overview]
Message-ID: <20140307.154142.488351276799532264.davem@davemloft.net> (raw)
In-Reply-To: <1394077948-8395-3-git-send-email-alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org>
From: Alistair Popple <alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org>
Date: Thu, 6 Mar 2014 14:52:25 +1100
> + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN
> + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
When an expression spans multiple lines, the lines should end with
operators rather than begin with them.
Also, it would be easier to read this call if parenthesis were put
around the third argument and then indented to match, f.e.:
out_be32(dev->reg, (in_be32(dev->reg) | WKUP_ETH_RGMIIEN |
WKUP_ETH_TX_OE | WKUP_ETH_RX_IE));
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-07 20:41 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 3:52 [PATCH 0/5] V2 IBM Akebono/PPC46GTR Support Alistair Popple
2014-03-06 3:52 ` [PATCH 1/5] SDHCI: Add a generic registration to the SDHCI platform driver Alistair Popple
2014-03-06 3:52 ` Alistair Popple
2014-03-06 3:52 ` [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-03-06 3:52 ` Alistair Popple
2014-03-07 20:41 ` David Miller [this message]
2014-03-07 20:41 ` David Miller
2014-03-07 21:02 ` rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver) Joe Perches
2014-03-07 21:02 ` Joe Perches
2014-03-07 21:02 ` Joe Perches
2014-03-07 21:23 ` rfc: checkpatch logical line continuations David Miller
2014-03-07 21:23 ` David Miller
2014-03-07 21:23 ` David Miller
2014-03-07 21:30 ` rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver) josh
2014-03-07 21:30 ` josh
2014-03-07 21:45 ` Joe Perches
2014-03-07 21:45 ` Joe Perches
2014-03-07 23:04 ` Dan Carpenter
2014-03-07 23:04 ` Dan Carpenter
2014-03-07 23:04 ` Dan Carpenter
2014-03-07 23:15 ` Joe Perches
2014-03-07 23:15 ` Joe Perches
2014-03-10 9:53 ` David Laight
2014-03-10 9:53 ` David Laight
2014-03-10 9:53 ` David Laight
2014-03-11 0:44 ` [PATCH 2/5 V2] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-03-11 0:44 ` Alistair Popple
2014-03-11 0:44 ` Alistair Popple
2014-05-02 0:48 ` Alistair Popple
2014-05-02 0:48 ` Alistair Popple
2014-05-02 0:48 ` Alistair Popple
2014-03-06 3:52 ` [PATCH 3/5] IBM Currituck: Clean up board specific code before adding Akebono code Alistair Popple
2014-03-06 3:52 ` [PATCH 4/5] IBM Akebono: Add the Akebono platform Alistair Popple
2014-05-01 9:27 ` [4/5] " Paul Bolle
2014-05-01 9:27 ` Paul Bolle
2014-05-01 9:27 ` Paul Bolle
2014-05-02 0:35 ` Alistair Popple
2014-05-02 0:35 ` Alistair Popple
2014-05-02 2:33 ` Benjamin Herrenschmidt
2014-05-02 2:33 ` Benjamin Herrenschmidt
2014-05-02 2:33 ` Benjamin Herrenschmidt
2014-05-02 8:06 ` [PATCH] IBM Akebono: Remove obsolete config select Alistair Popple
2014-05-02 8:06 ` Alistair Popple
2014-05-02 8:06 ` Alistair Popple
2014-06-13 11:56 ` Paul Bolle
2014-06-13 11:56 ` Paul Bolle
2014-06-13 11:56 ` Paul Bolle
2014-06-20 0:10 ` Alistair Popple
2014-06-20 0:10 ` Alistair Popple
2014-09-04 22:20 ` Paul Bolle
2014-09-04 22:20 ` Paul Bolle
2014-09-04 22:20 ` Paul Bolle
2014-09-05 2:39 ` Alistair Popple
2014-09-05 2:39 ` Alistair Popple
2014-09-05 2:39 ` Alistair Popple
2014-09-04 22:29 ` [4/5] IBM Akebono: Add the Akebono platform Paul Bolle
2014-09-04 22:29 ` Paul Bolle
2014-03-06 3:52 ` [PATCH 5/5] powerpc: Added PCI MSI support using the HSTA module Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307.154142.488351276799532264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alistair@popple.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.