From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qa0-f50.google.com ([209.85.216.50]:59247 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbaCGP0r (ORCPT ); Fri, 7 Mar 2014 10:26:47 -0500 Date: Fri, 7 Mar 2014 10:26:43 -0500 From: Tejun Heo To: laijs@cn.fujitsu.com Cc: linux-kernel@vger.kernel.org, Ivo van Doorn , Gertjan van Wingerde , Helmut Schaa , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/9] wireless/rt2x00: don't use PREPARE_WORK in rt2800usb.c Message-ID: <20140307152643.GF30778@htj.dyndns.org> (sfid-20140307_162703_030004_F39C7FED) References: <1392929071-16555-1-git-send-email-tj@kernel.org> <1392929071-16555-2-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1392929071-16555-2-git-send-email-tj@kernel.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Feb 20, 2014 at 03:44:23PM -0500, Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. > > Update rt2800usb.c to use INIT_WORK() instead of PREPARE_WORK(). As > the work item isn't in active use during rt2800usb_probe_hw(), this > doesn't cause any behavior difference. > > It would probably be best to route this with other related updates > through the workqueue tree. > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Ivo van Doorn > Cc: Gertjan van Wingerde > Cc: Helmut Schaa > Cc: linux-wireless@vger.kernel.org Applied to wq/for-3.15. Please holler if there's any objection. Thanks. -- tejun