From: Dave Jones <davej@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Motohiro Kosaki <Motohiro.Kosaki@us.fujitsu.com>,
Sasha Levin <sasha.levin@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Bob Liu <lliubbo@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"walken@google.com" <walken@google.com>,
Motohiro Kosaki JP <kosaki.motohiro@jp.fujitsu.com>,
"riel@redhat.com" <riel@redhat.com>,
"stable@kernel.org" <stable@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH] mm: remove BUG_ON() from mlock_vma_page()
Date: Tue, 11 Mar 2014 14:43:53 -0400 [thread overview]
Message-ID: <20140311184353.GA10764@redhat.com> (raw)
In-Reply-To: <5314A9E9.6090802@suse.cz>
On Mon, Mar 03, 2014 at 05:12:25PM +0100, Vlastimil Babka wrote:
> >> On 01/31/2014 03:33 PM, Andrew Morton wrote:
> >>> On Wed, 18 Dec 2013 08:42:49 +0800 Bob Liu<lliubbo@gmail.com> wrote:
> >>>
> >>>>> This BUG_ON() was triggered when called from try_to_unmap_cluster()
> >>>>> which didn't lock the page.
> >>>>> And it's safe to mlock_vma_page() without PageLocked, so this patch
> >>>>> fix this issue by removing that BUG_ON() simply.
> >>>>>
> >>> This patch doesn't appear to be going anywhere, so I will drop it.
> >>> Please let's check to see whether the bug still exists and if so,
> >>> start another round of bugfixing.
> >>
> >> This bug still happens on the latest -next kernel.
> >
> > Yeah, I recognized it. I'm preparing new patch. Thanks.
>
> What will be your approach? After we had the discussion some month ago
> about m(un)lock vs migration I've concluded that there is no race that
> page lock helps, and removing the BUG_ON() would be indeed correct. Just
> needs to be correctly explained and documentation updated as well.
This is not just a -next problem btw, I just hit this in 3.14-rc6
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-11 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 0:42 [PATCH] mm: remove BUG_ON() from mlock_vma_page() Bob Liu
2013-12-18 9:36 ` Vlastimil Babka
2013-12-18 10:26 ` Bob Liu
2013-12-18 19:31 ` Motohiro Kosaki
2013-12-18 22:30 ` Andrew Morton
2014-01-31 20:33 ` Andrew Morton
2014-02-23 19:32 ` Sasha Levin
2014-02-24 17:57 ` Motohiro Kosaki
2014-03-03 16:12 ` Vlastimil Babka
2014-03-11 18:43 ` Dave Jones [this message]
2014-03-20 9:18 ` Bob Liu
2014-03-20 10:36 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311184353.GA10764@redhat.com \
--to=davej@redhat.com \
--cc=Motohiro.Kosaki@us.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=stable@kernel.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.