From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 06/26] drm/i915: Wrap VMA binding Date: Tue, 18 Mar 2014 08:42:00 +0000 Message-ID: <20140318084200.GC13504@nuc-i3427.alporthouse.com> References: <1395121738-29126-1-git-send-email-benjamin.widawsky@intel.com> <1395121738-29126-7-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id D02212BBCF for ; Tue, 18 Mar 2014 01:42:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395121738-29126-7-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 17, 2014 at 10:48:38PM -0700, Ben Widawsky wrote: > This will be useful for some upcoming patches which do more platform > specific work. Having it in one central place just makes things a bit > cleaner and easier. > > There is a small functional change here. There are more calls to the > tracepoints. > > NOTE: I didn't actually end up using this patch for the intended purpose, but I > thought it was a nice patch to keep around. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_drv.h | 3 +++ > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > drivers/gpu/drm/i915/i915_gem_context.c | 2 +- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 5 +++-- > drivers/gpu/drm/i915/i915_gem_gtt.c | 16 ++++++++++++++-- > 5 files changed, 25 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index c59b707..b3e31fd 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2408,6 +2408,9 @@ bool i915_gem_obj_bound(struct drm_i915_gem_object *o, > struct i915_address_space *vm); > unsigned long i915_gem_obj_size(struct drm_i915_gem_object *o, > struct i915_address_space *vm); > +void i915_gem_bind_vma(struct i915_vma *vma, enum i915_cache_level, > + unsigned flags); > +void i915_gem_unbind_vma(struct i915_vma *vma); Being pedantic, this should be i915_vma_bind, i915_vma_unbind. -Chris -- Chris Wilson, Intel Open Source Technology Centre