From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4] dmaengine: sirf: enable generic dt binding for dma channels Date: Tue, 18 Mar 2014 13:20:01 +0100 Message-ID: <201403181320.01858.arnd@arndb.de> References: <1389190369-2012-1-git-send-email-21cnbao@gmail.com> <20140317045105.GB1976@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140317045105.GB1976-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Vinod Koul , Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Lars-Peter Clausen , DL-SHA-WorkGroupLinux , Rob Herring , Barry Song , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Monday 17 March 2014, Vinod Koul wrote: > On Sat, Mar 01, 2014 at 10:49:18AM +0800, Barry Song wrote: > > 2014-01-20 17:35 GMT+08:00 Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: > > > 2014/1/20 Vinod Koul : > > >> On Wed, Jan 08, 2014 at 10:12:49PM +0800, Barry Song wrote: > > >>> From: Barry Song > > >>> > > >>> move to support of_dma_request_slave_channel() and dma_request_slave_channel. > > >>> we add a xlate() to let dma clients be able to find right dma_chan by generic > > >>> "dmas" properties in dts. > > >>> > > >>> Cc: Mark Rutland > > >>> Cc: Lars-Peter Clausen > > >>> Signed-off-by: Barry Song > > >> Look okay, need an ACk from DT maintainers before I can apply... > > > > Hi Vinod, > > v5 is sent to devicetree list and there is no object. > > http://www.spinics.net/lists/devicetree/msg19677.html > > this patch is using general dt-binding for dma completely same with > > other dma drivers, there is no special binding here. > > so i think there is no reason to wait for merging since now updates > > for its clients e.g. SPI, UART have been in 3.14-rc. > I still need the ack for DT folks... Seems still missing :( I thought I'd looked at it before. The wording of the binding document could be clarified a little, but the binding itself is absolutely reasonable and the implementation looks correct. I would suggest you merge it as is. Acked-by: Arnd Bergmann Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 18 Mar 2014 13:20:01 +0100 Subject: [PATCH v4] dmaengine: sirf: enable generic dt binding for dma channels In-Reply-To: <20140317045105.GB1976@intel.com> References: <1389190369-2012-1-git-send-email-21cnbao@gmail.com> <20140317045105.GB1976@intel.com> Message-ID: <201403181320.01858.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 17 March 2014, Vinod Koul wrote: > On Sat, Mar 01, 2014 at 10:49:18AM +0800, Barry Song wrote: > > 2014-01-20 17:35 GMT+08:00 Barry Song <21cnbao@gmail.com>: > > > 2014/1/20 Vinod Koul : > > >> On Wed, Jan 08, 2014 at 10:12:49PM +0800, Barry Song wrote: > > >>> From: Barry Song > > >>> > > >>> move to support of_dma_request_slave_channel() and dma_request_slave_channel. > > >>> we add a xlate() to let dma clients be able to find right dma_chan by generic > > >>> "dmas" properties in dts. > > >>> > > >>> Cc: Mark Rutland > > >>> Cc: Lars-Peter Clausen > > >>> Signed-off-by: Barry Song > > >> Look okay, need an ACk from DT maintainers before I can apply... > > > > Hi Vinod, > > v5 is sent to devicetree list and there is no object. > > http://www.spinics.net/lists/devicetree/msg19677.html > > this patch is using general dt-binding for dma completely same with > > other dma drivers, there is no special binding here. > > so i think there is no reason to wait for merging since now updates > > for its clients e.g. SPI, UART have been in 3.14-rc. > I still need the ack for DT folks... Seems still missing :( I thought I'd looked at it before. The wording of the binding document could be clarified a little, but the binding itself is absolutely reasonable and the implementation looks correct. I would suggest you merge it as is. Acked-by: Arnd Bergmann Arnd