From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, sameo@linux.intel.com, lee.jones@linaro.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core
Date: Wed, 19 Mar 2014 09:09:20 +0000 [thread overview]
Message-ID: <20140319090920.GE1665@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140318174430.GI11706@sirena.org.uk>
On Tue, Mar 18, 2014 at 05:44:30PM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 05:22:31PM +0000, Charles Keepax wrote:
>
> > - /*
> > - * LDO1 can only be used to supply DCVDD so if it has no
> > - * consumers then DCVDD is supplied externally.
> > - */
> > - if (arizona->pdata.ldo1 &&
> > - arizona->pdata.ldo1->num_consumer_supplies == 0)
> > - arizona->external_dcvdd = true;
> > -
>
> Actually now that I look at this again one issue here - the reason this
> is in the core is that if the system is using an external DCVDD it may
> not be building the regulator driver at all (it won't do anything at
> runtime) so the flag would never get set if it's done by the regulator
> driver.
Ah... missed that. I will respin again.
Thanks,
Charles
next prev parent reply other threads:[~2014-03-19 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:22 [PATCH 0/5] Arizona regulator updates v2 Charles Keepax
2014-03-18 17:22 ` [PATCH 1/5] arizona: Correct small errors in the DT binding documentation Charles Keepax
2014-03-18 17:22 ` [PATCH 2/5] mfd: arizona: Fix and factor out read of device tree GPIOs Charles Keepax
2014-03-18 17:22 ` [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-18 17:44 ` Mark Brown
2014-03-19 9:09 ` Charles Keepax [this message]
2014-03-18 17:22 ` [PATCH 4/5] regulator: arizona-ldo1: Add processing of init_data from device tree Charles Keepax
2014-03-18 17:22 ` [PATCH 5/5] regulator: arizona-micsupp: " Charles Keepax
2014-03-19 10:18 [PATCH 0/5] Arizona regulator updates v3 Charles Keepax
2014-03-19 10:18 ` [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-21 10:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319090920.GE1665@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.