On Wed, Mar 19, 2014 at 01:13:50PM +0200, Peter Ujfalusi wrote: > On 03/18/2014 08:07 PM, Mark Brown wrote: > > OK, so is the patch an improvement or not? If it fixes some cases it's > > probably worth applying even if further fixes are still needed. > Some application might fail (like mplayer with 44.1KHz) with constraint on the > period size only. Without the constraint we will have constant pops at every > period when non aligned size has been selected - if the FIFO depth is > configured to more than 1, which is not yet the case in upstream. OK, given that the FIFO depth change isn't yet upstream it'd be a step backwards so I'll leave this for now.