From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Wed, 19 Mar 2014 15:03:38 +0000
Message-ID: <20140319150338.GA27717@strange.amr.corp.intel.com>
References: <1395172267-9203-1-git-send-email-sivachandra@chromium.org>
 <20140318130620.07fa8680@jbarnes-desktop>
 <CAGyQ6gzRPNRpCDHWLL3P6_+E52v2XjZuOfNOqrQ-=Zvc5aOPCA@mail.gmail.com>
 <20140319084438.GM30571@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2917D6E490
 for <intel-gfx@lists.freedesktop.org>; Wed, 19 Mar 2014 08:06:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140319084438.GM30571@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 19, 2014 at 09:44:38AM +0100, Daniel Vetter wrote:
> On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote:
> > On Tue, Mar 18, 2014 at 1:06 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > On Tue, 18 Mar 2014 12:51:07 -0700
> > > Siva Chandra <sivachandra@chromium.org> wrote:
> > >
> > >> This property helps one turn PSR "on" and "off" via xrandr.
> > >> The default value is same as that of the module param i915.enable_psr.
> > >>
> > >> Signed-off-by: Siva Chandra <sivachandra@google.com>
> > >> ---
> > >
> > > So are you using this in Chromium for disabling PSR in cases where it
> > > doesn't work?  Or to optimize power consumption when the kernel driver
> > > gets it wrong?  Or just for debug?
> > 
> > We are testing a few PSR panels; Having a knob to turn PSR on and off
> > would be of great convenience for manual testing and for test scripts.
> 
> Is the module param not good enough for that? Iirc we recheck that every
> time ...

(the module parameter is accessible through a file in sysfs:
  /sys/module/i915/parameters/enable_psr)

Alternatively, doesn't it look like something that belongs to debugfs?
ie not an API with a stability guarantee?

-- 
Damien