From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 3/4] drm/i915: Enabling pre-multiplied alpha
 drm property
Date: Wed, 19 Mar 2014 15:10:08 +0000
Message-ID: <20140319151008.GB27717@strange.amr.corp.intel.com>
References: <CAKMK7uE3yWRoirtu133JQUwPjhH+D228LFh-+Kk65vAGAj_xww@mail.gmail.com>
 <1394266879-20522-1-git-send-email-sagar.a.kamble@intel.com>
 <1394266879-20522-4-git-send-email-sagar.a.kamble@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5A8666E910
 for <intel-gfx@lists.freedesktop.org>; Wed, 19 Mar 2014 08:15:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394266879-20522-4-git-send-email-sagar.a.kamble@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: sagar.a.kamble@intel.com
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, "Srinivas, Vidya" <vidya.srinivas@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Mar 08, 2014 at 01:51:18PM +0530, sagar.a.kamble@intel.com wrote:
> From: Sagar Kamble <sagar.a.kamble@intel.com>
> 
> This patch enables property for changin the pixel format
> of plane to enable/disable pre-multiplied alpha format.
> Client has to set BIT(DRM_BLEND_PREMULTIPLIED_ALPHA) | 0x0/0x1
> to disable/enable pre-multiplied alpha format.
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: David Airlie <airlied@linux.ie>
> Signed-off-by: Srinivas, Vidya <vidya.srinivas@intel.com>
> Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>

Huum, the alpha being premultiplied or not seems to be a property of the
framebuffer to me, not of the plane. It seems to me that we should
define alternative premultiplied DRM_FORMATs and make the sprite planes
advertise support for premultiplied fbs in the format list when the
hardware indeed supports them.

-- 
Damien