From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/balloon: export balloon hotplug page stats to sysfs
Date: Thu, 20 Mar 2014 15:38:13 -0400 [thread overview]
Message-ID: <20140320193813.GB2433@localhost.localdomain> (raw)
In-Reply-To: <1395320213-29921-1-git-send-email-wei.liu2@citrix.com>
On Thu, Mar 20, 2014 at 12:56:53PM +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Konrad Wilk <konrad.wilk@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> drivers/xen/xen-balloon.c | 9 +++++++++
If you are doing that you also need to put information in
Documentation/sysfs/abi/something/somewhere.
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xen-balloon.c
> index e555845..2d4c5a8 100644
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -129,6 +129,11 @@ module_exit(balloon_exit);
> BALLOON_SHOW(current_kb, "%lu\n", PAGES2KB(balloon_stats.current_pages));
> BALLOON_SHOW(low_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_low));
> BALLOON_SHOW(high_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_high));
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> +BALLOON_SHOW(hotplug_kb, "%lu\n", PAGES2KB(balloon_stats.hotplug_pages));
> +BALLOON_SHOW(balloon_hotplug_kb, "%lu\n",
> + PAGES2KB(balloon_stats.balloon_hotplug));
> +#endif
>
> static DEVICE_ULONG_ATTR(schedule_delay, 0444, balloon_stats.schedule_delay);
> static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, balloon_stats.max_schedule_delay);
> @@ -206,6 +211,10 @@ static struct attribute *balloon_info_attrs[] = {
> &dev_attr_current_kb.attr,
> &dev_attr_low_kb.attr,
> &dev_attr_high_kb.attr,
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> + &dev_attr_hotplug_kb.attr,
> + &dev_attr_balloon_hotplug_kb.attr,
> +#endif
> NULL
> };
>
> --
> 1.7.10.4
>
prev parent reply other threads:[~2014-03-20 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:56 [PATCH] xen/balloon: export balloon hotplug page stats to sysfs Wei Liu
2014-03-20 13:21 ` David Vrabel
2014-03-20 14:01 ` Wei Liu
2014-03-21 13:02 ` David Vrabel
2014-03-21 13:34 ` Wei Liu
2014-03-20 19:38 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320193813.GB2433@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.