From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v2] drm/i915/vlv: Enabling the TLB invalidate bit in GFX Mode register Date: Fri, 21 Mar 2014 16:52:19 +0000 Message-ID: <20140321165219.GE18789@nuc-i3427.alporthouse.com> References: <20140321134534.GD18789@nuc-i3427.alporthouse.com> <1395415688-12474-1-git-send-email-sourab.gupta@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CCCB6E3A4 for ; Fri, 21 Mar 2014 09:52:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395415688-12474-1-git-send-email-sourab.gupta@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sourab.gupta@intel.com Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Akash Goel List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 21, 2014 at 08:58:08PM +0530, sourab.gupta@intel.com wrote: > From: Akash Goel > > This patch Enables the bit for TLB invalidate in GFX Mode register. > > According to bspec, When enabled this bit limits the invalidation > of the TLB only to batch buffer boundaries, to pipe_control > commands which have the TLB invalidation bit set and sync flushes. > If disabled, the TLB caches are flushed for every full flush of > the pipeline. > > v2: Explicitly enabling TLB invalidate bit instead of assuming > default 1 (Chris Wilson) Right, but there is nothing special about this code for vlv, all of gen7 share the same TLB invalidation code, and there is no documented reason not to do the switch. So do a cursory test on ivb/hsw and send a patch that doesn't say FIXME. -Chris -- Chris Wilson, Intel Open Source Technology Centre