From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR5WO-0002m9-OU for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:54:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR5WK-0001PV-HF for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:54:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR5WK-0001PP-7n for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:54:24 -0400 Date: Fri, 21 Mar 2014 19:54:15 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140321195415.GD14504@work-vm> References: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com> <1395429454-24690-4-git-send-email-fred.konrad@greensocs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395429454-24690-4-git-send-email-fred.konrad@greensocs.com> Subject: Re: [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: quintela@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, mrhines@us.ibm.com * fred.konrad@greensocs.com (fred.konrad@greensocs.com) wrote: > From: KONRAD Frederic > > This makes qemu_savevm_state public for reverse-execution. It's interesting that you're doing this repetitive snapshot; in some ways it's similar to Michael Hines's code for Fault tolerance ( http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg03042.html ) Dave > Signed-off-by: KONRAD Frederic > --- > include/sysemu/sysemu.h | 1 + > savevm.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 3915ce3..fe86615 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -78,6 +78,7 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict); > > void qemu_announce_self(void); > > +int qemu_savevm_state(QEMUFile *f); > bool qemu_savevm_state_blocked(Error **errp); > void qemu_savevm_state_begin(QEMUFile *f, > const MigrationParams *params); > diff --git a/savevm.c b/savevm.c > index d094fbb..e50b716 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -635,7 +635,7 @@ void qemu_savevm_state_cancel(void) > } > } > > -static int qemu_savevm_state(QEMUFile *f) > +int qemu_savevm_state(QEMUFile *f) > { > int ret; > MigrationParams params = { > -- > 1.8.1.4 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK