From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 14/26] drm/i915: Complete page table
 structures
Date: Sat, 22 Mar 2014 21:14:14 +0000
Message-ID: <20140322211414.GF4366@nuc-i3427.alporthouse.com>
References: <1395121738-29126-1-git-send-email-benjamin.widawsky@intel.com>
 <1395121738-29126-15-git-send-email-benjamin.widawsky@intel.com>
 <20140318090945.GE18530@nuc-i3427.alporthouse.com>
 <20140322201047.GC18765@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
 by gabe.freedesktop.org (Postfix) with ESMTP id B9B7A6E279
 for <intel-gfx@lists.freedesktop.org>; Sat, 22 Mar 2014 14:14:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140322201047.GC18765@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Mar 22, 2014 at 01:10:47PM -0700, Ben Widawsky wrote:
> On Tue, Mar 18, 2014 at 09:09:45AM +0000, Chris Wilson wrote:
> > On Mon, Mar 17, 2014 at 10:48:46PM -0700, Ben Widawsky wrote:
> > > Move the remaining members over to the new page table structures.
> > > 
> > > This can be squashed with the previous commit if desire. The reasoning
> > > is the same as that patch. I simply felt it is easier to review if split.
> > 
> > I'm not liking the shorter names much. Is there precedence elsewhere
> > (e.g. daddr)?
> > -Chris
> > 
> 
> I'm not particularly attached to "daddr." It was fun to say in my head.
> A lot of code does use "daddr" but it seems to vary between "dma",
> "device", data", "destination" Not exactly precedence.
> 
> Initially I had the prefix p[td]_daddr, but I thought you might complain
> about it because it's implicit. dma_addr seemed kinda redundant to me.
> 
> Recommendation?

I am still attached to dma_addr, as it seems to be common (or
dma_address) for dma-mapped addresses. But by the end, I had stopped
caring, so

Acked-by: Chris Wilson <chris@chris-wilson.co.uk>

I'll come back to this if nobody has a better idea and see if I can make
some sensisble suggestions, or just give in completely.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre