From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbaCWPKM (ORCPT ); Sun, 23 Mar 2014 11:10:12 -0400 Received: from www.linutronix.de ([62.245.132.108]:58116 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbaCWPKH (ORCPT ); Sun, 23 Mar 2014 11:10:07 -0400 Message-Id: <20140323150753.325835408@linutronix.de> User-Agent: quilt/0.60-1 Date: Sun, 23 Mar 2014 15:09:28 -0000 From: Thomas Gleixner To: LKML Cc: Julia Lawall , Andrew Morton , Chas Williams , atm , netdev Subject: [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path References: <20140323150557.288925975@linutronix.de> Content-Disposition: inline; filename=atm-firestream-use-del-timer-sync.patch X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device is about to vanish. So we need to make sure that the timer is completely stopped and the callback is not running on another CPU. Signed-off-by: Thomas Gleixner Cc: Chas Williams Cc: atm Cc: netdev --- drivers/atm/firestream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: tip/drivers/atm/firestream.c =================================================================== --- tip.orig/drivers/atm/firestream.c +++ tip/drivers/atm/firestream.c @@ -2000,7 +2000,7 @@ static void firestream_remove_one(struct fs_dprintk (FS_DEBUG_CLEANUP, "Freeing irq%d.\n", dev->irq); free_irq (dev->irq, dev); - del_timer (&dev->timer); + del_timer_sync (&dev->timer); atm_dev_deregister(dev->atm_dev); free_queue (dev, &dev->hp_txq);