From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS93N-0006pT-Ps for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS93J-0007b3-HW for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:52:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS93J-0007ZT-9H for qemu-devel@nongnu.org; Mon, 24 Mar 2014 13:52:49 -0400 Date: Mon, 24 Mar 2014 17:52:40 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140324175239.GJ3829@work-vm> References: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com> <1395429454-24690-4-git-send-email-fred.konrad@greensocs.com> <20140321195415.GD14504@work-vm> <5330499F.2080503@greensocs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5330499F.2080503@greensocs.com> Subject: Re: [Qemu-devel] [RFC PATCH 03/12] migration: make qemu_savevm_state public. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frederic Konrad Cc: mrhines@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, quintela@redhat.com * Frederic Konrad (fred.konrad@greensocs.com) wrote: > On 21/03/2014 20:54, Dr. David Alan Gilbert wrote: > >* fred.konrad@greensocs.com (fred.konrad@greensocs.com) wrote: > >>From: KONRAD Frederic > >> > >>This makes qemu_savevm_state public for reverse-execution. > >It's interesting that you're doing this repetitive snapshot; > >in some ways it's similar to Michael Hines's code for > >Fault tolerance ( http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg03042.html ) > > > >Dave > > Hi, > > Thanks for the link I missed this. > > Seems mc is using live migration and we just checkpoint the whole machine. > > That might be a good improvment. I doubt it directly; there's not that much difference between snapshot to file and migrate to file (if you follow the paths they take basically the same route; I think the only thing is that the snapshot mechanism allows you to save snapshots into an existing qcow2 file). However, I was more pointing out the overlap in problem - both of you needing to take regular snapshots (at probably as quick a rate as you can manage) but with different criteria for the lifetime and reason for restoration of the snap. Dave > > Fred > > > > >>Signed-off-by: KONRAD Frederic > >>--- > >> include/sysemu/sysemu.h | 1 + > >> savevm.c | 2 +- > >> 2 files changed, 2 insertions(+), 1 deletion(-) > >> > >>diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > >>index 3915ce3..fe86615 100644 > >>--- a/include/sysemu/sysemu.h > >>+++ b/include/sysemu/sysemu.h > >>@@ -78,6 +78,7 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict); > >> void qemu_announce_self(void); > >>+int qemu_savevm_state(QEMUFile *f); > >> bool qemu_savevm_state_blocked(Error **errp); > >> void qemu_savevm_state_begin(QEMUFile *f, > >> const MigrationParams *params); > >>diff --git a/savevm.c b/savevm.c > >>index d094fbb..e50b716 100644 > >>--- a/savevm.c > >>+++ b/savevm.c > >>@@ -635,7 +635,7 @@ void qemu_savevm_state_cancel(void) > >> } > >> } > >>-static int qemu_savevm_state(QEMUFile *f) > >>+int qemu_savevm_state(QEMUFile *f) > >> { > >> int ret; > >> MigrationParams params = { > >>-- > >>1.8.1.4 > >> > >> > >-- > >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK