From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 00/34] Add clang support for ARM and cleanups Date: Thu, 27 Mar 2014 17:34:39 +0100 Message-ID: <20140327163439.GL91759@deinos.phlegethon.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WTDGM-0006vw-1Y for xen-devel@lists.xenproject.org; Thu, 27 Mar 2014 16:34:42 +0000 Content-Disposition: inline In-Reply-To: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi, Thanks for this! At 16:55 +0000 on 25 Mar (1395762907), Julien Grall wrote: > The main goal of this patch series is to add support for Clang on ARM. > The work has been done with Clang 3.5 which is not yet release but have > a good support for ARM32. I think clang 3.4 may also be able to compile > Xen but I didn't try. Xen also builds for me with clang 3.2 with this series applied. You can add Reviewed-by: Tim Deegan to patch 1 and 3-30, with the following caveats: #11: assuming a v2 where the new fn is named get_stack_pointer() #13: for the v2 you already posted. #30: assuming v2 that does what Jan wants with the compat definitions. I'll look at patch #2 separately. Xen builds OK without it using clang 3.2; let me upgrade to 3.5 and see if there are better workarounds. Cheers, Tim.