From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Date: Fri, 28 Mar 2014 00:56:55 -0700 Message-ID: <20140328075655.GE22093@core.coreip.homeip.net> References: <1395310330-3232-1-git-send-email-hdegoede@redhat.com> <20140320172159.GA27400@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f172.google.com ([209.85.192.172]:48812 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbaC1H47 (ORCPT ); Fri, 28 Mar 2014 03:56:59 -0400 Content-Disposition: inline In-Reply-To: <20140320172159.GA27400@srcf.ucam.org> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Matthew Garrett Cc: Hans de Goede , Benjamin Tissoires , Peter Hutterer , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org On Thu, Mar 20, 2014 at 05:21:59PM +0000, Matthew Garrett wrote: > On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote: > > > Which in the end turns out to be much nicer too, since it gets rid of needing > > a udev-helper too. After this much too long introduction I'll let the patches > > speak for themselves. > > Yeah, I was coming to the conclusion that this was probably the best we > could do. It's unfortunate that "id" is already in use - we'd be able to > get away without any X server modifications otherwise. > > Long term we probably still want to tie serio devices to the ACPI > devices in case the vendor provides power management calls there, but we > can leave that until there's an actual example. I am still unsure if we shoudl be adding these new IDs to serio core... Can't the X driver take a peek at ACPI devices on it's own? Thanks. -- Dmitry