From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Date: Fri, 28 Mar 2014 01:17:39 -0700 Message-ID: <20140328081739.GG22093@core.coreip.homeip.net> References: <1395310330-3232-1-git-send-email-hdegoede@redhat.com> <20140320172159.GA27400@srcf.ucam.org> <20140328075655.GE22093@core.coreip.homeip.net> <53352EFB.8000309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:61225 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbaC1IRn (ORCPT ); Fri, 28 Mar 2014 04:17:43 -0400 Content-Disposition: inline In-Reply-To: <53352EFB.8000309@redhat.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Hans de Goede Cc: Matthew Garrett , Benjamin Tissoires , Peter Hutterer , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org On Fri, Mar 28, 2014 at 09:12:43AM +0100, Hans de Goede wrote: > Hi, > > On 03/28/2014 08:56 AM, Dmitry Torokhov wrote: > > On Thu, Mar 20, 2014 at 05:21:59PM +0000, Matthew Garrett wrote: > >> On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote: > >> > >>> Which in the end turns out to be much nicer too, since it gets rid of needing > >>> a udev-helper too. After this much too long introduction I'll let the patches > >>> speak for themselves. > >> > >> Yeah, I was coming to the conclusion that this was probably the best we > >> could do. It's unfortunate that "id" is already in use - we'd be able to > >> get away without any X server modifications otherwise. > >> > >> Long term we probably still want to tie serio devices to the ACPI > >> devices in case the vendor provides power management calls there, but we > >> can leave that until there's an actual example. > > > > I am still unsure if we shoudl be adding these new IDs to serio core... > > Can't the X driver take a peek at ACPI devices on it's own? > > The problem is there is no way for userspace to know which /sys/devices/pnp0/00:xx > device is the serio bus host. Practically speaking you should not care - there is only one touchpad in Lenovos. Thanks. -- Dmitry