From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Date: Fri, 28 Mar 2014 01:50:31 -0700 Message-ID: <20140328085031.GM22093@core.coreip.homeip.net> References: <1395310330-3232-1-git-send-email-hdegoede@redhat.com> <20140320172159.GA27400@srcf.ucam.org> <20140328075655.GE22093@core.coreip.homeip.net> <20140328082004.GA6801@srcf.ucam.org> <20140328082452.GH22093@core.coreip.homeip.net> <20140328082704.GC6801@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:36261 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbaC1Iue (ORCPT ); Fri, 28 Mar 2014 04:50:34 -0400 Content-Disposition: inline In-Reply-To: <20140328082704.GC6801@srcf.ucam.org> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Matthew Garrett Cc: Hans de Goede , Benjamin Tissoires , Peter Hutterer , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org On Fri, Mar 28, 2014 at 08:27:04AM +0000, Matthew Garrett wrote: > On Fri, Mar 28, 2014 at 01:24:52AM -0700, Dmitry Torokhov wrote: > > On Fri, Mar 28, 2014 at 08:20:04AM +0000, Matthew Garrett wrote: > > > On Fri, Mar 28, 2014 at 12:56:55AM -0700, Dmitry Torokhov wrote: > > > > > > > I am still unsure if we shoudl be adding these new IDs to serio core... > > > > Can't the X driver take a peek at ACPI devices on it's own? > > > > > > In the (admittedly unlikely) event of multiple PS/2 trackpads, how do > > > you know which one corresponds to which ACPI device? > > > > So far I have not seen a single instance of a laptop with 2 touchpads > > and I doubt external PS/2 ones will ever make come back. > > Right, we can hack around it based on what we've seen so far. But it > seems more attractive to fix it in such a way that we won't behave > inappropriately even if someone does do something utterly unexpected in > future. For instance, some ARM devices have i8042-like serio - if the > underlying device is exposed in device tree, it'd be nice to be able to > expose that to userspace without having to modify the core X code. I wonder if on ARM they have the same split description for AUX and KBD ports or of they have proper i8042 parent. ACPI way of describing PS/2 devices is ugly - keyboard gets ports and mice/touchpads are portless and everyone knows that they should use the same as keyboard. I am unconvinced that just storing a string as firmware ID would solve anything other than quirky Lenovos. Thanks. -- Dmitry