All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] systemd: disable build for unsupported architectures.
Date: Fri, 28 Mar 2014 17:24:48 +0100	[thread overview]
Message-ID: <20140328162447.GA7725@pc-eric> (raw)
In-Reply-To: <20140328121156.6d49c688@skate>

Hi!
On Fri, Mar 28, 2014 at 12:11:56PM +0100, Thomas Petazzoni wrote:
> Dear Eric Le Bihan,
>
> On Fri, 28 Mar 2014 11:16:07 +0100, Eric Le Bihan wrote:
> > Systemd only supports the architectures defined in
> > src/shared/architecture.h. This list does not contain ARC, Blackfin,
> > Xtensa, Microblaze and Nios2, so this package is disabled for these
> > architectures.
[...]
>
> Maybe it's better to use positive logic here, and only explicitly allow
> systemd on the architectures that it supports. This way if tomorrow we
> add support for a new architecture, we won't get weird failures.
>
> In package/systemd/Config.in:
>
> config BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS
> 	bool
> 	default y if BR2_arm || BR2_powerpc || BR2_...
>
> and then use "depends on BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed.
Thanks for the advice! I noticed BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT in
package/qt/Config.in follows the same logic.

Best regards,
ELB

      reply	other threads:[~2014-03-28 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 10:16 [Buildroot] [PATCH 1/1] systemd: disable build for unsupported architectures Eric Le Bihan
2014-03-28 11:11 ` Thomas Petazzoni
2014-03-28 16:24   ` Eric Le Bihan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328162447.GA7725@pc-eric \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.