All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] system: add ability to pass additional users tables.
Date: Fri, 28 Mar 2014 17:50:46 +0100	[thread overview]
Message-ID: <20140328165046.GA3303@free.fr> (raw)
In-Reply-To: <20140328111056.GA28624@pc-eric>

Eric, All,

On 2014-03-28 12:10 +0100, Eric Le Bihan spake thusly:
> On Thu, Mar 27, 2014 at 07:19:15PM +0100, Yann E. MORIN wrote:
> > Eric, All,
> >
> [...]
> >
> > There is a discrepancy bewteen the description commit log and this help
> > text, and the actual behaviour. The commit log and help text both
> > explain this can be a space-separated list of files, but in the code you
> > just treat it as if it were a unique file:
> >
> >     ifneq ($$(ROOTFS_USERS_TABLE),)
> >         cat $$(ROOTFS_USERS_TABLE) > $(USERS_TABLE)
> >     endif
> >
> > I think you should do something like:
> >
> >     $(foreach f,$$(ROOTFS_USERS_TABLE),cat $$(f) >>$(USERS_TABLE)$(sep))
> In fact I use the same trick as for ROOTFS_DEVICE_TABLES: whether
> ROOTFS_USERS_TABLE is 'foo' or 'foo bar quux', the invocation of `cat` is
> valid, as `cat` takes a list of filenames as arguments. So no need to loop
> on a list.

Oh, right. OK, then.

> But it is true that I should use the plural form ROOTFS_USERS_TABLES.

Yes, please.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-03-28 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 16:19 [Buildroot] [RFC] add ability to pass additional users tables Eric Le Bihan
2014-03-27 16:19 ` [Buildroot] [PATCH 1/1] system: " Eric Le Bihan
2014-03-27 18:19   ` Yann E. MORIN
2014-03-28 11:10     ` Eric Le Bihan
2014-03-28 16:50       ` Yann E. MORIN [this message]
2014-04-20 17:21   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328165046.GA3303@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.