From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WTbzg-0000uV-JL
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:59:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WTbzY-0007rd-KO
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:59:08 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:43722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WTbzY-0007rN-B7
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 14:59:00 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Fri, 28 Mar 2014 18:58:58 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 894BA17D8041
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2014 18:59:42 +0000 (GMT)
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s2SIwhsl64815328
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2014 18:58:43 GMT
Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s2SIwsAi015247
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2014 14:58:55 -0400
Date: Fri, 28 Mar 2014 19:58:49 +0100
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20140328195849.1a107dbc@bahia.local>
In-Reply-To: <CAFEAcA8N3dTB-KZvWPEQ_zg=5sL7cviKEorLHivBaAiXdGcMhA@mail.gmail.com>
References: <20140328105709.21018.88000.stgit@bahia.local>
	<20140328105756.21018.57522.stgit@bahia.local>
	<20140328181326.22c0a6a5@bahia.local> <5335AFA7.9010306@suse.de>
	<20140328183729.5aeb724e@bahia.local>
	<CAFEAcA_vF=Cb=5hzt5GdBV7+DXCMEKoN=JyC5qxCu02RO_hzUw@mail.gmail.com>
	<20140328190428.29c8e95f@bahia.local>
	<CAFEAcA8N3dTB-KZvWPEQ_zg=5sL7cviKEorLHivBaAiXdGcMhA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 6/8] virtio-scsi: use virtio wrappers to
 access headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marc Zyngier <marc.zyngier@arm.com>, Rusty Russell <rusty@rustcorp.com.au>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Fri, 28 Mar 2014 18:14:55 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 28 March 2014 18:04, Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> > Ok, I am now convinced. Let's make struct VirtIODevice* be the
> > first argument for all helpers and kill the AddressSpace* one.
> > Unless you envision we could end up with different address spaces
> > accross multiple virtio devices
> 
> Well, any one virtio device would always use the same AddressSpace,
> but consider a system model with two separate models of different
> PCs in it, each of which has  its own self-contained memory, PCI
> bus and virtio devices...
> 

A per-device AddressSpace* property would be more appropriate then. Correct ?

> thanks
> -- PMM
> 

-- 
Gregory Kurz                                     kurzgreg@fr.ibm.com
                                                 gkurz@linux.vnet.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.