All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Jamie Iles <jamie@jamieiles.com>, Alan Tull <atull@altera.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dinh Nguyen <dinguyen@altera.com>
Subject: Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()
Date: Mon, 31 Mar 2014 17:22:00 +0100	[thread overview]
Message-ID: <20140331162200.GB2579@page.Home> (raw)
In-Reply-To: <CACRpkdbu6LKLntP2J=ypLTrAYscvzf5WjPYb-E+RKH_vAPEYHg@mail.gmail.com>

On Tue, Mar 25, 2014 at 09:37:50PM +0100, Linus Walleij wrote:
> Aha Jamie not even on the original thread. Here.
> 
> On Tue, Mar 25, 2014 at 9:37 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior
> > <bigeasy@linutronix.de> wrote:
> >
> >> This looks kinda wrong I didn't manage to fully test it.
> >> The driver calls irq_alloc_domain_generic_chips() which creates a gc and
> >> adds it to gc_list. The driver later then calls irq_setup_generic_chip()
> >> which also initializes the gc and adds it to the gc_list() and this
> >> corrupts the list.
> >> I can't find a single chip in tree which uses both functions so I think
> >> that irq_setup_generic_chip() can be dropped.
> >>
> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >
> > Jamie: comments?

I don't have anything to add to either yours or Alan's comments.  I'll 
be more than happy to review the versions with the generic helpers if 
I'm copied onto the review.

Thanks,

Jamie

  reply	other threads:[~2014-03-31 16:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 19:55 two patches for the synposys gpio controller Sebastian Andrzej Siewior
2014-03-20 19:55 ` Sebastian Andrzej Siewior
2014-03-20 19:55 ` [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-25 20:37   ` Linus Walleij
2014-03-25 20:37     ` Linus Walleij
2014-03-31 16:22       ` Jamie Iles [this message]
2014-03-20 19:55 ` [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront Sebastian Andrzej Siewior
2014-03-20 20:20   ` delicious quinoa
2014-03-22 12:37     ` Sebastian Andrzej Siewior
2014-03-25 20:43       ` Linus Walleij
2014-03-25 21:17         ` Sebastian Andrzej Siewior
2014-04-08 13:20           ` Linus Walleij
     [not found] ` <1395345324-18299-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-03-20 19:55   ` [PATCH 3/3] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-03-20 19:55     ` Sebastian Andrzej Siewior
2014-03-21 17:24     ` Gerhard Sittig
2014-03-21 19:10       ` Sebastian Andrzej Siewior
2014-03-21 19:10         ` Sebastian Andrzej Siewior
2014-03-21 22:06         ` delicious quinoa
2014-03-21 18:14     ` delicious quinoa
2014-03-21 19:08       ` Sebastian Andrzej Siewior
     [not found]       ` <CANk1AXRa4V1ADNaT+T3pYF4zyxni9Y8rmU9UYRoA_7NxW8KWEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-21 22:15         ` delicious quinoa
2014-03-21 22:15           ` delicious quinoa
2014-03-22 11:28           ` Sebastian Andrzej Siewior
2014-03-26 15:29             ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331162200.GB2579@page.Home \
    --to=jamie@jamieiles.com \
    --cc=atull@altera.com \
    --cc=bigeasy@linutronix.de \
    --cc=dinguyen@altera.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.