Re: [PATCH V4 02/12] TestSupport.pm: introduce create_iso_xorriso for creating isos

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Apr 02, 2014 at 05:01:00PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH V4 02/12] TestSupport.pm: introduce create_iso_xorriso for creating isos"):
> > ... and convert ts-redhat-install to make use of it.
> 
> Thanks:
> 
> > +
> > +                      create_iso_xorriso
> 
> Why the additional blank line ?
> 

To separate this function from other category. More functions will come.

I will also rename this function to iso_* according to your suggestion
on later patch.

> > +#---------- ISO images ----------
> > +sub create_iso_xorriso ($$$$;@) {
> > +    my ($ho,$iso,$dir,$isotimeout,@xopts) = @_;
> > +
> > +    target_install_packages_norec($ho, qw(xorriso));
> 
> You (sadly) mustn't put this here because multiple simultaneous
> executions of this function on the same host might cause multiple
> simultaneous invocations of apt on the same host, which would fail due
> to apt's locking.
> 

OK.

> > -    my @isogen_base= qw(-R -J -T);
> > +    my @isogen_base= qw(-as mkisofs -R -J);
> 
> I haven't checked these xorriso options; I'll take your word for them.
> 

For genisoimage:
-R     Generate SUSP and RR records using the Rock Ridge protocol to
       further describe the files on the ISO9660 filesystem.
-J     Generate Joliet directory records in addition to regular ISO9660
       filenames.
-T     Generate  a  file  TRANS.TBL  in each directory on the CD-ROM,
       which can be used on non-Rock Ridge-capable systems to
       help establish the correct filenames.

For xorriso with mkisofs personality:
-R    same as above (taken from man 8 mkisofs)
-J    same as above (taken from man 8 mkisofs)
-T    same as above, but will be ignored by xorriso

Wei.

> Thanks,
> Ian.