All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: cfreeman@nvidia.com
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: jack: export gpio detect
Date: Thu, 3 Apr 2014 23:07:15 +0100	[thread overview]
Message-ID: <20140403220715.GG14763@sirena.org.uk> (raw)
In-Reply-To: <1396562635-9753-1-git-send-email-cfreeman@nvidia.com>


[-- Attachment #1.1: Type: text/plain, Size: 575 bytes --]

On Thu, Apr 03, 2014 at 03:03:55PM -0700, cfreeman@nvidia.com wrote:
> From: Christopher Freeman <cfreeman@nvidia.com>
> 
> Export the gpio detect function so machine drivers
> may call it.  Interrupts for the jack may be disabled
> during sleep, so this allows a machine driver to have
> the jack status updated during resume.

It seems better to have explicit callbacks for this doesn't it, ideally
ones that get triggered by the core without the machine driver having to
do anything?  This is a common need so having to open code it would be a
bit depressing.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2014-04-03 22:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 22:03 [PATCH] ASoC: jack: export gpio detect cfreeman
2014-04-03 22:07 ` Mark Brown [this message]
2014-04-08 20:40   ` Christopher Freeman
2014-04-10 23:24     ` Christopher Freeman
2014-04-11 10:12       ` Mark Brown
2014-04-14 19:55     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2014-03-26 21:38 cfreeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403220715.GG14763@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=cfreeman@nvidia.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.