From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V8 PATCH 6/8] pvh dom0: allow get_pg_owner for translated domains Date: Fri, 4 Apr 2014 17:59:34 -0700 Message-ID: <20140404175934.7e2c881c@mantra.us.oracle.com> References: <1395452357-1598-1-git-send-email-mukesh.rathor@oracle.com> <1395452357-1598-7-git-send-email-mukesh.rathor@oracle.com> <5330098302000078000013B8@nat28.tlf.novell.com> <533ACDC4.6090003@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WWExT-00035t-Lf for xen-devel@lists.xenproject.org; Sat, 05 Apr 2014 00:59:43 +0000 In-Reply-To: <533ACDC4.6090003@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: xen-devel@lists.xenproject.org, keir.xen@gmail.com, tim@xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org On Tue, 1 Apr 2014 15:31:32 +0100 George Dunlap wrote: > On 03/24/2014 09:31 AM, Jan Beulich wrote: > >>>> On 22.03.14 at 02:39, wrote: > >> With pvh, a translated domain, get_pg_owner must allow foreign > >> mappings. > > > > And what about HVM domains? Can you really safely drop this namely > > with the possible use of this function in an earlier patch of this > > series? (Without that new use, the change of course is safe > > assuming that PV domains are never translated; I'm not sure however > > whether this is being explicitly guaranteed anywhere these days, or > > just "a fact"). > > It's probably a better idea to make it "if( !is_pv_domain() || > paging_mode_translate() )" (Or some variant thereof. Yup, thats the way it was in the earlier patches, not sure how/when it got changed. will put pvh check back there. thanks mukesh