All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, linux-kernel@vger.kernel.org, konrad@kernel.org,
	david.vrabel@Citrix.com, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: Re: [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.
Date: Wed, 9 Apr 2014 11:27:06 -0400	[thread overview]
Message-ID: <20140409152706.GF5860__25411.9530822665$1397057333$gmane$org@phenom.dumpdata.com> (raw)
In-Reply-To: <534529A40200007800007055@nat28.tlf.novell.com>

On Wed, Apr 09, 2014 at 10:06:12AM +0100, Jan Beulich wrote:
> >>> On 08.04.14 at 19:25, <konrad@kernel.org> wrote:
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -3470,6 +3470,9 @@ static long hvm_vcpu_op(
> >      case VCPUOP_stop_singleshot_timer:
> >      case VCPUOP_register_vcpu_info:
> >      case VCPUOP_register_vcpu_time_memory_area:
> > +    case VCPUOP_down:
> > +    case VCPUOP_up:
> > +    case VCPUOP_is_up:
> 
> This, if I checked it properly, leaves only VCPUOP_initialise,
> VCPUOP_send_nmi, and VCPUOP_get_physid disallowed for HVM.
> None of which look inherently bad to be used by HVM (but
> VCPUOP_initialise certainly would need closer checking), so I
> wonder whether either the wrapper shouldn't be dropped altogether
> or at least be converted from a white list approach to a black list one.

I was being conservative here because I did not want to allow the
other ones without at least testing it.

Perhaps that can be done as a seperate patch and this just as
a bug-fix?

> 
> Jan
> 

  parent reply	other threads:[~2014-04-09 15:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 20:44 33 VCPUs in HVM guests with live migration with Linux hangs Konrad Rzeszutek Wilk
2014-04-07  8:32 ` Ian Campbell
2014-04-08 17:25   ` [PATCH] Fixes for more than 32 VCPUs migration for HVM guests (v1) konrad
2014-04-08 17:25     ` [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating konrad
2014-04-08 17:25     ` konrad
2014-04-08 18:18       ` [Xen-devel] " Roger Pau Monné
2014-04-08 18:53         ` Konrad Rzeszutek Wilk
2014-04-09  7:37           ` Roger Pau Monné
2014-04-09 15:34             ` Konrad Rzeszutek Wilk
2014-04-09 15:34             ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-04-09 15:38               ` David Vrabel
2014-04-09 15:55                 ` Konrad Rzeszutek Wilk
2014-04-09 15:55                 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-04-09 15:38               ` David Vrabel
2014-04-09  7:37           ` Roger Pau Monné
2014-04-09  8:33           ` Ian Campbell
2014-04-09  8:33           ` [Xen-devel] " Ian Campbell
2014-04-09  9:04             ` Roger Pau Monné
2014-04-09  9:04             ` [Xen-devel] " Roger Pau Monné
2014-04-08 18:53         ` Konrad Rzeszutek Wilk
2014-04-08 18:18       ` Roger Pau Monné
2014-04-09  9:06       ` Jan Beulich
2014-04-09  9:06       ` Jan Beulich
2014-04-09 15:27         ` Konrad Rzeszutek Wilk
2014-04-09 15:36           ` Jan Beulich
2014-04-22 18:34             ` Konrad Rzeszutek Wilk
2014-04-23  8:57               ` Jan Beulich
2014-04-23  8:57               ` Jan Beulich
2014-04-22 18:34             ` Konrad Rzeszutek Wilk
2014-04-09 15:36           ` Jan Beulich
2014-04-09 15:27         ` Konrad Rzeszutek Wilk [this message]
2014-04-08 17:25     ` [LINUX PATCH 2/2] xen/pvhvm: Support more than 32 VCPUs " konrad
2014-04-08 17:25     ` konrad
2014-04-09  8:03       ` Jan Beulich
2014-04-09  8:03       ` Jan Beulich
2014-04-08 17:25   ` [PATCH] Fixes for more than 32 VCPUs migration for HVM guests (v1) konrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20140409152706.GF5860__25411.9530822665$1397057333$gmane$org@phenom.dumpdata.com' \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@Citrix.com \
    --cc=keir@xen.org \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.