All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Miller <davem@davemloft.net>
Cc: greearb@candelatech.com, eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] macvlan: Move broadcasts into a work queue
Date: Fri, 11 Apr 2014 09:59:06 +0800	[thread overview]
Message-ID: <20140411015906.GB31251@gondor.apana.org.au> (raw)
In-Reply-To: <20140410.214023.849284639345029049.davem@davemloft.net>

On Thu, Apr 10, 2014 at 09:40:23PM -0400, David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Wed, 9 Apr 2014 01:23:49 +0800
> 
> > On Tue, Apr 08, 2014 at 09:48:40AM -0700, Ben Greear wrote:
> >> 
> >> At least for ARPs, maybe we could inspect the packet and only
> >> deliver to interfaces configured with the MAC that is being
> >> ARPed for (or ones that are in promisc)?
> > 
> > Yes this would definitely be a great optimisation.
> 
> Yes and you can use the direct rather than the workqueue path.

This would be a worthy optimisation for bridge.c too.  In fact,
I wonder if it would be possible to share some of the broadcast/
multicast logic between macvlan and bridge.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2014-04-11  1:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<20140407075347.GA26461@gondor.apana.org.au>
2014-04-07  7:55 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-07 18:48   ` Stephen Hemminger
2014-04-08  7:15     ` Herbert Xu
2014-04-08 16:27       ` David Miller
2014-04-07  7:55 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-07 14:07   ` Eric Dumazet
2014-04-07 14:23     ` Herbert Xu
2014-04-08 16:48       ` Ben Greear
2014-04-08 17:23         ` Herbert Xu
2014-04-11  1:40           ` David Miller
2014-04-11  1:59             ` Herbert Xu [this message]
2014-04-11  2:09               ` Eric Dumazet
2014-04-11  2:13                 ` Herbert Xu
2014-04-11  8:45                   ` David Laight
2014-04-11 16:11                     ` Ben Greear
2014-04-11 16:20                       ` Ben Greear
2014-04-11 16:17                   ` Ben Greear
2014-04-08 16:55   ` Stephen Hemminger
2014-04-08 17:14     ` Joe Perches
2014-04-09  8:50     ` Herbert Xu
2014-04-09 10:10       ` David Laight
2014-04-10 12:59         ` Herbert Xu
2014-04-10 14:50           ` David Laight
2014-04-07  7:53 [0/2] macvlan: Handle broadcasts in " Herbert Xu
2014-04-17  5:45 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-20 22:19   ` David Miller
2014-04-17  5:45 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-20 22:20   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140411015906.GB31251@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.