All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: use current instead of task in syscall_get_arch
@ 2014-04-11  2:25 ` Eric Paris
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Paris @ 2014-04-11  2:25 UTC (permalink / raw)
  To: linux-audit
  Cc: Eric Paris, markos.chandras, Paul Burton, James Hogan, linux-mips

In commit 6e345746 Markos started using task to determine 64bit vs
32bit instead of it being completely CONFIG based.

In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
across the entire system.

This obviously results in a build failure when Linus's and the audit
tree were merged.  This patch should be applied as part of the merge
conflict, as both sides of the merge are correct and the failure happens
AT the merge.

The fix is simple.  The task is always current.  Use current.

Signed-off-by: Eric Paris <eparis@redhat.com>
Cc: markos.chandras@imgtec.com
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/include/asm/syscall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
index d79cded..1258884 100644
--- a/arch/mips/include/asm/syscall.h
+++ b/arch/mips/include/asm/syscall.h
@@ -131,7 +131,7 @@ static inline int syscall_get_arch(void)
 {
 	int arch = EM_MIPS;
 #ifdef CONFIG_64BIT
-	if (!test_tsk_thread_flag(task, TIF_32BIT_REGS))
+	if (!test_tsk_thread_flag(current, TIF_32BIT_REGS))
 		arch |= __AUDIT_ARCH_64BIT;
 #endif
 #if defined(__LITTLE_ENDIAN)
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] MIPS: use current instead of task in syscall_get_arch
@ 2014-04-11  2:25 ` Eric Paris
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Paris @ 2014-04-11  2:25 UTC (permalink / raw)
  To: linux-audit; +Cc: Paul Burton, James Hogan, markos.chandras, linux-mips

In commit 6e345746 Markos started using task to determine 64bit vs
32bit instead of it being completely CONFIG based.

In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
across the entire system.

This obviously results in a build failure when Linus's and the audit
tree were merged.  This patch should be applied as part of the merge
conflict, as both sides of the merge are correct and the failure happens
AT the merge.

The fix is simple.  The task is always current.  Use current.

Signed-off-by: Eric Paris <eparis@redhat.com>
Cc: markos.chandras@imgtec.com
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
---
 arch/mips/include/asm/syscall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
index d79cded..1258884 100644
--- a/arch/mips/include/asm/syscall.h
+++ b/arch/mips/include/asm/syscall.h
@@ -131,7 +131,7 @@ static inline int syscall_get_arch(void)
 {
 	int arch = EM_MIPS;
 #ifdef CONFIG_64BIT
-	if (!test_tsk_thread_flag(task, TIF_32BIT_REGS))
+	if (!test_tsk_thread_flag(current, TIF_32BIT_REGS))
 		arch |= __AUDIT_ARCH_64BIT;
 #endif
 #if defined(__LITTLE_ENDIAN)
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: use current instead of task in syscall_get_arch
  2014-04-11  2:25 ` Eric Paris
@ 2014-04-11  2:43   ` Richard Guy Briggs
  -1 siblings, 0 replies; 6+ messages in thread
From: Richard Guy Briggs @ 2014-04-11  2:43 UTC (permalink / raw)
  To: Eric Paris
  Cc: linux-audit, Paul Burton, James Hogan, markos.chandras, linux-mips

On 14/04/10, Eric Paris wrote:
> In commit 6e345746 Markos started using task to determine 64bit vs
> 32bit instead of it being completely CONFIG based.
> 
> In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
> across the entire system.
> 
> This obviously results in a build failure when Linus's and the audit
> tree were merged.  This patch should be applied as part of the merge
> conflict, as both sides of the merge are correct and the failure happens
> AT the merge.
> 
> The fix is simple.  The task is always current.  Use current.
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>
> Cc: markos.chandras@imgtec.com
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: linux-mips@linux-mips.org

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

> ---
>  arch/mips/include/asm/syscall.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index d79cded..1258884 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -131,7 +131,7 @@ static inline int syscall_get_arch(void)
>  {
>  	int arch = EM_MIPS;
>  #ifdef CONFIG_64BIT
> -	if (!test_tsk_thread_flag(task, TIF_32BIT_REGS))
> +	if (!test_tsk_thread_flag(current, TIF_32BIT_REGS))
>  		arch |= __AUDIT_ARCH_64BIT;
>  #endif
>  #if defined(__LITTLE_ENDIAN)
> -- 
> 1.9.0

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: use current instead of task in syscall_get_arch
@ 2014-04-11  2:43   ` Richard Guy Briggs
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Guy Briggs @ 2014-04-11  2:43 UTC (permalink / raw)
  To: Eric Paris
  Cc: linux-mips, James Hogan, linux-audit, markos.chandras, Paul Burton

On 14/04/10, Eric Paris wrote:
> In commit 6e345746 Markos started using task to determine 64bit vs
> 32bit instead of it being completely CONFIG based.
> 
> In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
> across the entire system.
> 
> This obviously results in a build failure when Linus's and the audit
> tree were merged.  This patch should be applied as part of the merge
> conflict, as both sides of the merge are correct and the failure happens
> AT the merge.
> 
> The fix is simple.  The task is always current.  Use current.
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>
> Cc: markos.chandras@imgtec.com
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: linux-mips@linux-mips.org

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

> ---
>  arch/mips/include/asm/syscall.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index d79cded..1258884 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -131,7 +131,7 @@ static inline int syscall_get_arch(void)
>  {
>  	int arch = EM_MIPS;
>  #ifdef CONFIG_64BIT
> -	if (!test_tsk_thread_flag(task, TIF_32BIT_REGS))
> +	if (!test_tsk_thread_flag(current, TIF_32BIT_REGS))
>  		arch |= __AUDIT_ARCH_64BIT;
>  #endif
>  #if defined(__LITTLE_ENDIAN)
> -- 
> 1.9.0

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: use current instead of task in syscall_get_arch
@ 2014-04-11 10:18     ` Markos Chandras
  0 siblings, 0 replies; 6+ messages in thread
From: Markos Chandras @ 2014-04-11 10:18 UTC (permalink / raw)
  To: Richard Guy Briggs, Eric Paris
  Cc: linux-audit, Paul Burton, James Hogan, linux-mips

On 04/11/2014 03:43 AM, Richard Guy Briggs wrote:
> On 14/04/10, Eric Paris wrote:
>> In commit 6e345746 Markos started using task to determine 64bit vs
>> 32bit instead of it being completely CONFIG based.
>>
>> In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
>> across the entire system.
>>
>> This obviously results in a build failure when Linus's and the audit
>> tree were merged.  This patch should be applied as part of the merge
>> conflict, as both sides of the merge are correct and the failure happens
>> AT the merge.
>>
>> The fix is simple.  The task is always current.  Use current.
>>
>> Signed-off-by: Eric Paris <eparis@redhat.com>
>> Cc: markos.chandras@imgtec.com
>> Cc: Paul Burton <paul.burton@imgtec.com>
>> Cc: James Hogan <james.hogan@imgtec.com>
>> Cc: linux-mips@linux-mips.org
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

Looks good to me. Thanks for taking care of that.

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

-- 
markos

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: use current instead of task in syscall_get_arch
@ 2014-04-11 10:18     ` Markos Chandras
  0 siblings, 0 replies; 6+ messages in thread
From: Markos Chandras @ 2014-04-11 10:18 UTC (permalink / raw)
  To: Richard Guy Briggs, Eric Paris
  Cc: linux-audit, Paul Burton, James Hogan, linux-mips

On 04/11/2014 03:43 AM, Richard Guy Briggs wrote:
> On 14/04/10, Eric Paris wrote:
>> In commit 6e345746 Markos started using task to determine 64bit vs
>> 32bit instead of it being completely CONFIG based.
>>
>> In commit 5e937a9a we dropped the 'task' argument to syscall_get_arch()
>> across the entire system.
>>
>> This obviously results in a build failure when Linus's and the audit
>> tree were merged.  This patch should be applied as part of the merge
>> conflict, as both sides of the merge are correct and the failure happens
>> AT the merge.
>>
>> The fix is simple.  The task is always current.  Use current.
>>
>> Signed-off-by: Eric Paris <eparis@redhat.com>
>> Cc: markos.chandras@imgtec.com
>> Cc: Paul Burton <paul.burton@imgtec.com>
>> Cc: James Hogan <james.hogan@imgtec.com>
>> Cc: linux-mips@linux-mips.org
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

Looks good to me. Thanks for taking care of that.

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

-- 
markos

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-04-11 10:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11  2:25 [PATCH] MIPS: use current instead of task in syscall_get_arch Eric Paris
2014-04-11  2:25 ` Eric Paris
2014-04-11  2:43 ` Richard Guy Briggs
2014-04-11  2:43   ` Richard Guy Briggs
2014-04-11 10:18   ` Markos Chandras
2014-04-11 10:18     ` Markos Chandras

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.