From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 0/5] drm/i915: Add the support of dual BSD
 rings on BDW GT3
Date: Fri, 11 Apr 2014 10:57:51 +0200
Message-ID: <20140411085751.GX9262@phenom.ffwll.local>
References: <1397008796-3595-1-git-send-email-yakui.zhao@intel.com>
 <20140409144558.GE9262@phenom.ffwll.local>
 <1397100526.2039.137.camel@genxdev-ykzhao.sh.intel.com>
 <20140410065825.GI9262@phenom.ffwll.local>
 <1397118514.2039.176.camel@genxdev-ykzhao.sh.intel.com>
 <20140410090451.GS9262@phenom.ffwll.local>
 <1397177788.2039.192.camel@genxdev-ykzhao.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48])
 by gabe.freedesktop.org (Postfix) with ESMTP id 62D566ED5B
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Apr 2014 01:57:54 -0700 (PDT)
Received: by mail-ee0-f48.google.com with SMTP id b57so3812488eek.7
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Apr 2014 01:57:53 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1397177788.2039.192.camel@genxdev-ykzhao.sh.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 11, 2014 at 08:56:28AM +0800, Zhao Yakui wrote:
> On Thu, 2014-04-10 at 03:04 -0600, Daniel Vetter wrote:
> > On Thu, Apr 10, 2014 at 04:28:34PM +0800, Zhao Yakui wrote:
> > > BTW: Does it need to check all the flags defined in i915_drm.h or the
> > > exported flag returned by i915_get_parameter?
> > 
> > I don't have i915_get_parameter anywhere in my sources, so no idea what
> > you mean ...
> 
> Sorry that the function should be i915_getparam. It is called by the
> I915_GETPARAM ioctl to query the flag supported by the driver.

Ah, now I understand. The idea is to test all fields of the structure
exhaustively (so also rsvd to make sure it's 0). Well except for the
buffer count field since we have tests for that already.

For the reasons see my two blog posts on the topic:

http://blog.ffwll.ch/2013/11/testing-requirements-for-drmi915.html

http://blog.ffwll.ch/2013/11/botching-up-ioctls.html

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch