All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6slevk: Add SPI NOR flash support
Date: Sat, 12 Apr 2014 22:59:57 +0200	[thread overview]
Message-ID: <201404122259.57743.marex@denx.de> (raw)
In-Reply-To: <CAD6G_RS8gSnuOYbTDR_n8ZsjW+zohD9XS=Gje1ZVkEsc3SLfOg@mail.gmail.com>

On Saturday, April 12, 2014 at 07:50:35 PM, Jagan Teki wrote:
[...]

> >> > diff --git a/include/configs/mx6slevk.h b/include/configs/mx6slevk.h
> >> > index 1876dbf..3d05a64 100644
> >> > --- a/include/configs/mx6slevk.h
> >> > +++ b/include/configs/mx6slevk.h
> >> > @@ -10,6 +10,7 @@
> >> > 
> >> >  #define __CONFIG_H
> >> >  
> >> >  #include <asm/arch/imx-regs.h>
> >> > 
> >> > +#include <asm/imx-common/gpio.h>
> >> > 
> >> >  #include <linux/sizes.h>
> >> >  #include "mx6_common.h"
> >> > 
> >> > @@ -196,4 +197,15 @@
> >> > 
> >> >  #define CONFIG_CMD_CACHE
> >> >  #endif
> >> > 
> >> > +#define CONFIG_CMD_SF
> >> > +#ifdef CONFIG_CMD_SF
> >> > +#define CONFIG_SPI_FLASH
> >> > +#define CONFIG_SPI_FLASH_STMICRO
> >> > +#define CONFIG_MXC_SPI
> >> > +#define CONFIG_SF_DEFAULT_BUS          0
> >> 
> >> *no_need* to define DEFAULT_BUS as 0 - it's default.
> > 
> > We better be explicit here.
> 
> *explicit* fine - don't you think defining a default value may
> increase extra macro which looks *duplicate*

No.

Explicitly defining the value in the board file serves well for people who will 
dig in the SPI on this particular MX6 board as it will make it immediatelly 
clear to them which SPI bus is the SPI NOR sitting on. It makes things easily 
tweakable as well.

Also, is there any reason to put asterisks around random words in the sentence?

Best regards,
Marek Vasut

  reply	other threads:[~2014-04-12 20:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 11:39 [U-Boot] [PATCH] mx6slevk: Add SPI NOR flash support Fabio Estevam
2014-04-11 11:58 ` Marek Vasut
2014-04-11 12:10   ` Fabio Estevam
2014-04-11 12:12 ` Marek Vasut
2014-04-11 23:11 ` Sam Catch
2014-04-12 10:30 ` Jagan Teki
2014-04-12 15:11   ` Marek Vasut
2014-04-12 17:50     ` Jagan Teki
2014-04-12 20:59       ` Marek Vasut [this message]
2014-04-14 16:03         ` Jagan Teki
2014-04-28 12:01 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201404122259.57743.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.