From: David Miller <davem@davemloft.net>
To: luto@amacapital.net
Cc: dborkman@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
ast@plumgrid.com, eparis@redhat.com, james.l.morris@oracle.com,
keescook@chromium.org
Subject: Re: [PATCH] seccomp: fix populating a0-a5 syscall args in 32-bit x86 BPF
Date: Mon, 14 Apr 2014 16:24:52 -0400 (EDT) [thread overview]
Message-ID: <20140414.162452.1169041476405438694.davem@davemloft.net> (raw)
In-Reply-To: <534C4179.7070704@amacapital.net>
From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 14 Apr 2014 13:13:45 -0700
> I think this description is wrong. (unsigned long *) &sd->args[1] is
> the right location, at least on 32-bit little-endian architectures.
It absolutely is not.
The thing is a u64, and we must respect that type in a completely
portable way.
Daniel's change is %100 correct, portable, and doesn't have any
ugly ifdef crap.
If you want to optimize this, and potentially break it again, do
it in the next merge window not now.
I'm going to apply Daniel's patch.
next prev parent reply other threads:[~2014-04-14 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 19:02 [PATCH] seccomp: fix populating a0-a5 syscall args in 32-bit x86 BPF Daniel Borkmann
2014-04-14 20:13 ` Andy Lutomirski
2014-04-14 20:24 ` David Miller [this message]
2014-04-14 20:28 ` Andy Lutomirski
2014-04-15 6:31 ` Alexei Starovoitov
2014-04-15 17:46 ` Andy Lutomirski
2014-04-15 22:52 ` Linus Torvalds
2014-04-15 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414.162452.1169041476405438694.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=dborkman@redhat.com \
--cc=eparis@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.