All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com, ja@ssi.bg,
	cwang@twopensource.com
Subject: Re: [Patch net 1/3] net: move LOOPBACK_IFINDEX to include/net/flow.h
Date: Tue, 15 Apr 2014 15:06:00 -0400 (EDT)	[thread overview]
Message-ID: <20140415.150600.1198094454060493410.davem@davemloft.net> (raw)
In-Reply-To: <1397525608-11592-1-git-send-email-xiyou.wangcong@gmail.com>


Cong, first of all, I'd like you to combine patches #1 and #2.

Also, Julian made it clear that several other changes needed happen
besides the single fib_validate_source() call site you are modifying
in patch #3.

He also said, for example, that the flow4_iif assignment in
__fib_validate_source() needs adjusting as well.

He furthermore said that other assignments of zero to flow4_iif
in netfilter and elsewhere must be adjusted as well.

Please also provide a proper 0/N patch posting next time explaining
exactly what the series does and why it is necessary.

  parent reply	other threads:[~2014-04-15 19:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  1:33 [Patch net 1/3] net: move LOOPBACK_IFINDEX to include/net/flow.h Cong Wang
2014-04-15  1:33 ` [Patch net 2/3] ipv4,fib: pass LOOPBACK_IFINDEX instead of 0 to flowi4_iif Cong Wang
2014-04-15 20:26   ` Julian Anastasov
2014-04-15 23:25     ` Cong Wang
2014-04-15  1:33 ` [Patch net 3/3] ipv4,fib: pass 0 instead of LOOPBACK_IFINDEX to fib_validate_source() Cong Wang
2014-04-15 19:06 ` David Miller [this message]
2014-04-15 19:13   ` [Patch net 1/3] net: move LOOPBACK_IFINDEX to include/net/flow.h Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140415.150600.1198094454060493410.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cwang@twopensource.com \
    --cc=ebiederm@xmission.com \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.