On Tue, Apr 15, 2014 at 05:57:39PM +0800, Barry Song wrote: > 2014-04-15 17:26 GMT+08:00 Mark Brown : > > OK, that needs fixing. That code predates anyone doing DMA. > if it is out of specification, it seems fixing spidev.c is not enough > as spi transfer actually needs an precondition of tx!=rx now. Well, it's enough to avoid bugs. Adding the validation to make sure nobody introduces the problem again is nice too but isn't as urgent.