All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: David Milburn <dmilburn@redhat.com>
Cc: linux-ide@vger.kernel.org, agordeev@redhat.com
Subject: Re: [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL
Date: Tue, 15 Apr 2014 14:20:01 -0400	[thread overview]
Message-ID: <20140415182001.GF30990@htj.dyndns.org> (raw)
In-Reply-To: <20140415181812.GA11614@dhcp-10-15-1-70.hsv.redhat.com>

On Tue, Apr 15, 2014 at 01:18:12PM -0500, David Milburn wrote:
> This patch also solves the problem, would this better?

Yes, this is a lot better.  Alexander, does this look good to you?
Also, shouldn't this cc stable?

> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 5a0bf8e..831b1b4 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1236,14 +1236,14 @@ int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis)
>  		struct ahci_port_priv *pp = host->ports[i]->private_data;
>  
>  		/* pp is NULL for dummy ports */
> -		if (pp)
> +		if (pp) {
>  			desc = pp->irq_desc;
> -		else
> -			desc = dev_driver_string(host->dev);
>  
> -		rc = devm_request_threaded_irq(host->dev,
> -			irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
> -			desc, host->ports[i]);
> +			rc = devm_request_threaded_irq(host->dev,
> +						       irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
> +						       desc, host->ports[i]);
> +		}
> +
>  		if (rc)
>  			goto out_free_irqs;
>  	}

-- 
tejun

  reply	other threads:[~2014-04-15 18:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 21:47 [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL David Milburn
2014-04-15 16:33 ` Tejun Heo
2014-04-15 18:18   ` David Milburn
2014-04-15 18:20     ` Tejun Heo [this message]
2014-04-16  7:39       ` Alexander Gordeev
2014-04-16 15:19         ` Tejun Heo
2014-04-16 16:28           ` David Milburn
2014-04-16 18:51           ` Alexander Gordeev
2014-04-16 19:14             ` Tejun Heo
2014-04-17  8:29               ` Alexander Gordeev
2014-04-17 13:29                 ` Tejun Heo
2014-04-17 12:44                   ` Alexander Gordeev
2014-04-17 13:45                     ` Tejun Heo
2014-04-17 13:07                       ` Alexander Gordeev
2014-04-17 14:09                         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140415182001.GF30990@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=agordeev@redhat.com \
    --cc=dmilburn@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.