From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Gordeev Subject: Re: [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL Date: Thu, 17 Apr 2014 14:44:36 +0200 Message-ID: <20140417124436.GC2270@dhcp-26-207.brq.redhat.com> References: <1397512038-8419-1-git-send-email-dmilburn@redhat.com> <20140415163309.GB30990@htj.dyndns.org> <20140415181812.GA11614@dhcp-10-15-1-70.hsv.redhat.com> <20140415182001.GF30990@htj.dyndns.org> <20140416073919.GB2349@dhcp-26-207.brq.redhat.com> <20140416151932.GF1257@htj.dyndns.org> <20140416185105.GA21640@dhcp-26-207.brq.redhat.com> <20140416191454.GC22569@htj.dyndns.org> <20140417082934.GA30477@dhcp-26-207.brq.redhat.com> <20140417132942.GB15326@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbaDQNmx (ORCPT ); Thu, 17 Apr 2014 09:42:53 -0400 Content-Disposition: inline In-Reply-To: <20140417132942.GB15326@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: David Milburn , linux-ide@vger.kernel.org On Thu, Apr 17, 2014 at 09:29:42AM -0400, Tejun Heo wrote: > On Thu, Apr 17, 2014 at 10:29:35AM +0200, Alexander Gordeev wrote: > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > > index e45b18e..9f1169a 100644 > > --- a/drivers/ata/ahci.c > > +++ b/drivers/ata/ahci.c > > @@ -1240,6 +1240,8 @@ int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis) > > irq + i, ahci_hw_interrupt, > > ahci_thread_fn, IRQF_SHARED, > > pp->irq_desc, host->ports[i]); > > + else > > + disable_irq(irq + i); > > Hmmm? Request failed. Why would it require an explicit disable? if (pp) rc = devm_request_threaded_irq(..., irq + i, ...) else disable_irq(irq + i); > -- > tejun -- Regards, Alexander Gordeev agordeev@redhat.com