From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: Rockchip RK3188 I2C driver
Date: Fri, 18 Apr 2014 00:10:12 +0100 [thread overview]
Message-ID: <20140417231012.GI12304@sirena.org.uk> (raw)
In-Reply-To: <1917043.Q4CxE5T68K@phil>
On Thu, Apr 17, 2014 at 03:27:36PM +0200, Heiko St?bner wrote:
> Interestingly, when looking through the regmap_config struct, it already
> contains the "write_flag_mask", described as "Mask to be set in the top byte of
> the register when doing a write.", which sounds a lot like what we need, only
> that it's two bytes for us instead of the current one.
> So I guess the easiest way would be to make write_flag_mask somehow usable for
> us, because it looks like regmap will handle the rest on its own already.
> And then teach syscon to set this flag and about volatile registers in general,
> because it doesn't seem to handle them yet.
How about a val_set_bits_mask or something? That's not a good name, I'm
short on inspiration right now though.
Another option is to do something with pad_bits to tell regmap to insert
a block of set bits. Not sure if that's sensible for MMIO though, it's
more sensible for I2C or SPI style register maps.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140418/dc6a2150/attachment.sig>
next prev parent reply other threads:[~2014-04-17 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 0:19 Rockchip RK3188 I2C driver Max Schwarz
2014-04-15 8:42 ` Heiko Stübner
2014-04-15 17:25 ` Heiko Stübner
2014-04-15 17:55 ` Mark Brown
2014-04-15 18:39 ` Heiko Stübner
2014-04-15 18:50 ` Mark Brown
2014-04-17 0:04 ` Max Schwarz
2014-04-17 13:27 ` Heiko Stübner
2014-04-17 23:10 ` Mark Brown [this message]
2014-04-17 18:38 ` Mark Brown
2014-04-17 23:06 ` Max Schwarz
2014-04-18 9:06 ` Heiko Stübner
2014-04-18 9:30 ` Max Schwarz
2014-04-18 10:03 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417231012.GI12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.