From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/irq: track the irq installed in drm_irq_install in dev->irq Date: Wed, 23 Apr 2014 09:27:58 +0200 Message-ID: <20140423072756.GC31226@ulmo> References: <1397252175-14227-11-git-send-email-daniel.vetter@ffwll.ch> <1398199460-21508-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1721188294==" Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 7774B6E9D3 for ; Wed, 23 Apr 2014 00:29:18 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id c13so411740eek.9 for ; Wed, 23 Apr 2014 00:29:17 -0700 (PDT) In-Reply-To: <1398199460-21508-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Laurent Pinchart , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1721188294== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vEao7xgI/oilGqZ+" Content-Disposition: inline --vEao7xgI/oilGqZ+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 22, 2014 at 10:44:20PM +0200, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index 589e865832cd..7cf407bbfed5 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -249,14 +249,16 @@ static inline int drm_dev_to_irq(struct drm_device = *dev) > */ > int drm_irq_install(struct drm_device *dev) > { > - int ret; > + int ret, irq; > unsigned long sh_flags =3D 0; > char *irqname; > =20 > + irq =3D drm_dev_to_irq(dev); I think the assignment could have happened either when the variable is declared, or... > + > if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ)) > return -EINVAL; > =20 > - if (drm_dev_to_irq(dev) =3D=3D 0) > + if (irq =3D=3D 0) =2E.. right above this, since it is where it is first used (it may not be necessary to query it before here at all if the driver doesn't set DRIVER_HAVE_IRQ). But I realize that that's pure bike-shedding, so either way: Reviewed-by: Thierry Reding --vEao7xgI/oilGqZ+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTV2t8AAoJEN0jrNd/PrOh3UwP/3gJZITMxpL3jp+1RbVrLUhN 8peQ/nOWG/HX6PsXErYWZOjEpVJ6tiJkcf6X2ydsg97Zwt4XB6iwQOCg2jngRh81 lNK2NTKQDRvyQQRZ1AauLl481U5TjPIPchuvNvLfBposi4vJYWrdvhXEKD90T5o0 jAM7qb+pP/KBbMau1UlAC4Y2m6ZJC2okhyT3ulul2pd0onvBFoPky5txlkb+bC6N 2AZ0cP+aqI4pxbtQX/em1PaAl6yAE7Y4n+8OACOPCbEQSq32yNTfz+j66xmbkrjH x6yYVPDC22mXEf7B/ZzR6M6MuggcfVh8QRca86c7zvLV4rWsb8CVRSYCbxXN3bQx mwTgBnPvQRZfkVM0XZArJH8Sto88xhzzFW/fVmozrimyJA/j8zbxikBY0o3t1Uzm t7KzLJD8bZcIimvY3xqs8+JaCcjDiv2uHR2hms9r2RTmFFSljvyUa/J0s88/kqRX QbNWxJ/rVr9NYYtgdOjdg/cetkJVmp2fqucsVQM2XCz9i8kUeOgmb2SdkGSAcxfP 1DCjNTAa+fRw+HOamQmH/XRyK6EhhOdOnxKCO1cqlkiqjkDEWnLehNIT5Pt/CaJc OZiDKTFg9yHF6wZ87XqRaCbgJpfZO/1mUyixnHh+o6qCZCh+jsw6rmNgE0F95/2J yszYxr6tLz1JAntYWcW/ =rDYo -----END PGP SIGNATURE----- --vEao7xgI/oilGqZ+-- --===============1721188294== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1721188294==--