From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Date: Wed, 23 Apr 2014 10:24:09 +0200 Message-ID: <20140423082409.GC24355@kwain> References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from top.free-electrons.com ([176.31.233.9]:55135 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755203AbaDWIYM (ORCPT ); Wed, 23 Apr 2014 04:24:12 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Rob Herring Cc: Sebastian Hesselbarth , Tejun Heo , zmxu@marvell.com, Jisheng Zhang , "linux-kernel@vger.kernel.org" , linux-ide@vger.kernel.org, Alexandre Belloni , "linux-arm-kernel@lists.infradead.org" Rob, On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote: > On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring = wrote: > > On Tue, Apr 22, 2014 at 10:38 AM, Antoine T=E9nart > > wrote: > >> Add support for the Berlin SoCs AHCI SATA controller allowing to > >> interface with devices like external hard drives. >=20 > One more thing. >=20 > >> + nports =3D readl(hpriv->mmio + HOST_PORTS_IMPL); > >> + > >> + /* force_map is modified only if the property is found */ > >> + of_property_read_u32(np, "marvell,force-port-map", &force_= map); >=20 > This property does not appear to be documented. I'll update it regarding Sebastian comments, or maybe drop it if it is possible to enable each port individually. >=20 > >> + if (force_map) > >> + nports =3D force_map; >=20 > You don't need this as your comment says, you can just do: >=20 > of_property_read_u32(np, "marvell,force-port-map", &nports); >=20 > nports will only be changed if property is present. Sure. Thanks! Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757529AbaDWIYQ (ORCPT ); Wed, 23 Apr 2014 04:24:16 -0400 Received: from top.free-electrons.com ([176.31.233.9]:55135 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755203AbaDWIYM (ORCPT ); Wed, 23 Apr 2014 04:24:12 -0400 Date: Wed, 23 Apr 2014 10:24:09 +0200 From: Antoine =?iso-8859-1?Q?T=E9nart?= To: Rob Herring Cc: Sebastian Hesselbarth , Tejun Heo , zmxu@marvell.com, Jisheng Zhang , "linux-kernel@vger.kernel.org" , linux-ide@vger.kernel.org, Alexandre Belloni , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Message-ID: <20140423082409.GC24355@kwain> References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob, On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote: > On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring wrote: > > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart > > wrote: > >> Add support for the Berlin SoCs AHCI SATA controller allowing to > >> interface with devices like external hard drives. > > One more thing. > > >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); > >> + > >> + /* force_map is modified only if the property is found */ > >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); > > This property does not appear to be documented. I'll update it regarding Sebastian comments, or maybe drop it if it is possible to enable each port individually. > > >> + if (force_map) > >> + nports = force_map; > > You don't need this as your comment says, you can just do: > > of_property_read_u32(np, "marvell,force-port-map", &nports); > > nports will only be changed if property is present. Sure. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (Antoine =?iso-8859-1?Q?T=E9nart?=) Date: Wed, 23 Apr 2014 10:24:09 +0200 Subject: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs In-Reply-To: References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> Message-ID: <20140423082409.GC24355@kwain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Rob, On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote: > On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring wrote: > > On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart > > wrote: > >> Add support for the Berlin SoCs AHCI SATA controller allowing to > >> interface with devices like external hard drives. > > One more thing. > > >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); > >> + > >> + /* force_map is modified only if the property is found */ > >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); > > This property does not appear to be documented. I'll update it regarding Sebastian comments, or maybe drop it if it is possible to enable each port individually. > > >> + if (force_map) > >> + nports = force_map; > > You don't need this as your comment says, you can just do: > > of_property_read_u32(np, "marvell,force-port-map", &nports); > > nports will only be changed if property is present. Sure. Thanks! Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com