From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs Date: Wed, 23 Apr 2014 11:50:55 +0100 Message-ID: <20140423105055.GI21613@lee--X1> References: <1398213110-28135-1-git-send-email-courtney.cavin@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f173.google.com ([209.85.212.173]:46690 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbaDWKvB (ORCPT ); Wed, 23 Apr 2014 06:51:01 -0400 Received: by mail-wi0-f173.google.com with SMTP id z2so4671473wiv.6 for ; Wed, 23 Apr 2014 03:51:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398213110-28135-1-git-send-email-courtney.cavin@sonymobile.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Courtney Cavin Cc: Samuel Ortiz , Josh Cartwright , Grant Likely , Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org > From: Josh Cartwright >=20 > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdra= gon > 800 series SoC family. This driver exists largely as a glue mfd comp= onent, > it exists to be an owner of an SPMI regmap for children devices > described in device tree. >=20 > Signed-off-by: Josh Cartwright > Signed-off-by: Courtney Cavin > --- > drivers/mfd/Kconfig | 13 +++++++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/pm8x41.c | 63 ++++++++++++++++++++++++++++++++++++++++++= ++++++++++ > 3 files changed, 77 insertions(+) > create mode 100644 drivers/mfd/pm8x41.c >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3383412..f5ff799 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -502,6 +502,19 @@ config MFD_PM8921_CORE > Say M here if you want to include support for PM8921 chip as a mo= dule. > This will build a module called "pm8921-core". > =20 > +config MFD_PM8X41 > + bool "Qualcomm PM8x41 PMIC" > + depends on ARCH_QCOM depends on OF? > + select REGMAP_SPMI > + help > + This enables basic support for the Qualcomm 8941 and 8841 PMICs. > + These PMICs are currently used with the Snapdragon 800 series of > + SoCs. Note, that this will only be useful paired with descriptio= ns > + of the independent functions as children nodes in the device tree= =2E > + > + Say M here if you want to include support for the PM8x41 series a= s a > + module. The module will be called "pm8x41". > + > config MFD_RDC321X > tristate "RDC R-321x southbridge" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 2851275..f0df41d 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -151,6 +151,7 @@ obj-$(CONFIG_MFD_SI476X_CORE) +=3D si476x-core.o > obj-$(CONFIG_MFD_CS5535) +=3D cs5535-mfd.o > obj-$(CONFIG_MFD_OMAP_USB_HOST) +=3D omap-usb-host.o omap-usb-tll.o > obj-$(CONFIG_MFD_PM8921_CORE) +=3D pm8921-core.o ssbi.o > +obj-$(CONFIG_MFD_PM8X41) +=3D pm8x41.o > obj-$(CONFIG_TPS65911_COMPARATOR) +=3D tps65911-comparator.o > obj-$(CONFIG_MFD_TPS65090) +=3D tps65090.o > obj-$(CONFIG_MFD_AAT2870_CORE) +=3D aat2870-core.o > diff --git a/drivers/mfd/pm8x41.c b/drivers/mfd/pm8x41.c > new file mode 100644 > index 0000000..c85e0d6 > --- /dev/null > +++ b/drivers/mfd/pm8x41.c > @@ -0,0 +1,63 @@ > +/* Copyright (c) 2013, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or mod= ify > + * it under the terms of the GNU General Public License version 2 an= d > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > +#include > +#include > +#include > +#include > +#include > + > +static const struct regmap_config pm8x41_regmap_config =3D { > + .reg_bits =3D 16, > + .val_bits =3D 8, > + .max_register =3D 0xFFFF, I've never seen this many registers registered before. Are you sure you want to regmap the entire bank? > +}; > + > +static int pm8x41_remove_child(struct device *dev, void *unused) > +{ > + platform_device_unregister(to_platform_device(dev)); > + return 0; > +} > + > +static void pm8x41_remove(struct spmi_device *sdev) > +{ > + device_for_each_child(&sdev->dev, NULL, pm8x41_remove_child); > +} Nit: It's strange to see the .remove above the .probe. > +static int pm8x41_probe(struct spmi_device *sdev) > +{ > + struct regmap *regmap; > + > + regmap =3D devm_regmap_init_spmi_ext(sdev, &pm8x41_regmap_config); > + if (IS_ERR(regmap)) { > + dev_dbg(&sdev->dev, "regmap creation failed.\n"); This is not debug, it's an error. > + return PTR_ERR(regmap); > + } > + > + return of_platform_populate(sdev->dev.of_node, NULL, NULL, &sdev->d= ev); > +} > + > +static const struct of_device_id pm8x41_id_table[] =3D { > + { .compatible =3D "qcom,pm8841", }, > + { .compatible =3D "qcom,pm8941", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, pm8x41_id_table); > + > +static struct spmi_driver pm8x41_driver =3D { > + .probe =3D pm8x41_probe, > + .remove =3D pm8x41_remove, > + .driver =3D { > + .name =3D "pm8x41", > + .of_match_table =3D pm8x41_id_table, of_match_ptr() > + }, > +}; > +module_spmi_driver(pm8x41_driver); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog