From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v1 5/7] mtd: fsl-quadspi: get the dummy cycles for DDR Quad read from the DT property Date: Wed, 23 Apr 2014 21:48:50 +0200 Message-ID: <201404232148.51034.marex@denx.de> References: <1398248215-26768-6-git-send-email-b32955@freescale.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398248215-26768-6-git-send-email-b32955@freescale.com> Sender: linux-doc-owner@vger.kernel.org To: Huang Shijie Cc: dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wednesday, April 23, 2014 at 12:16:53 PM, Huang Shijie wrote: > Check the "spi-nor,ddr-quad-read-dummy" DT property to get the > dummy cycles for DDR quad read. > > Signed-off-by: Huang Shijie > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c > b/drivers/mtd/spi-nor/fsl-quadspi.c index 8d659a2..15bdeb9 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -883,6 +883,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > for_each_available_child_of_node(dev->of_node, np) { > const struct spi_device_id *id; > char modalias[40]; > + u32 dummy = 0; > > /* skip the holes */ > if (!has_second_chip) > @@ -918,6 +919,12 @@ static int fsl_qspi_probe(struct platform_device > *pdev) if (ret < 0) > goto map_failed; > > + /* Set the dummy cycles for the DDR Quad Read */ > + ret = of_property_read_u32(np, "spi-nor,ddr-quad-read-dummy", > + &dummy); > + if (!ret && dummy > 0 && dummy < 8) > + nor->read_dummy = dummy; Is there any reason for the upper limit on number of dummy cycles ? Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut To: Huang Shijie Subject: Re: [PATCH v1 5/7] mtd: fsl-quadspi: get the dummy cycles for DDR Quad read from the DT property Date: Wed, 23 Apr 2014 21:48:50 +0200 References: <1398248215-26768-6-git-send-email-b32955@freescale.com> In-Reply-To: <1398248215-26768-6-git-send-email-b32955@freescale.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201404232148.51034.marex@denx.de> Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday, April 23, 2014 at 12:16:53 PM, Huang Shijie wrote: > Check the "spi-nor,ddr-quad-read-dummy" DT property to get the > dummy cycles for DDR quad read. > > Signed-off-by: Huang Shijie > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c > b/drivers/mtd/spi-nor/fsl-quadspi.c index 8d659a2..15bdeb9 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -883,6 +883,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > for_each_available_child_of_node(dev->of_node, np) { > const struct spi_device_id *id; > char modalias[40]; > + u32 dummy = 0; > > /* skip the holes */ > if (!has_second_chip) > @@ -918,6 +919,12 @@ static int fsl_qspi_probe(struct platform_device > *pdev) if (ret < 0) > goto map_failed; > > + /* Set the dummy cycles for the DDR Quad Read */ > + ret = of_property_read_u32(np, "spi-nor,ddr-quad-read-dummy", > + &dummy); > + if (!ret && dummy > 0 && dummy < 8) > + nor->read_dummy = dummy; Is there any reason for the upper limit on number of dummy cycles ? Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Wed, 23 Apr 2014 21:48:50 +0200 Subject: [PATCH v1 5/7] mtd: fsl-quadspi: get the dummy cycles for DDR Quad read from the DT property In-Reply-To: <1398248215-26768-6-git-send-email-b32955@freescale.com> References: <1398248215-26768-6-git-send-email-b32955@freescale.com> Message-ID: <201404232148.51034.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday, April 23, 2014 at 12:16:53 PM, Huang Shijie wrote: > Check the "spi-nor,ddr-quad-read-dummy" DT property to get the > dummy cycles for DDR quad read. > > Signed-off-by: Huang Shijie > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c > b/drivers/mtd/spi-nor/fsl-quadspi.c index 8d659a2..15bdeb9 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -883,6 +883,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > for_each_available_child_of_node(dev->of_node, np) { > const struct spi_device_id *id; > char modalias[40]; > + u32 dummy = 0; > > /* skip the holes */ > if (!has_second_chip) > @@ -918,6 +919,12 @@ static int fsl_qspi_probe(struct platform_device > *pdev) if (ret < 0) > goto map_failed; > > + /* Set the dummy cycles for the DDR Quad Read */ > + ret = of_property_read_u32(np, "spi-nor,ddr-quad-read-dummy", > + &dummy); > + if (!ret && dummy > 0 && dummy < 8) > + nor->read_dummy = dummy; Is there any reason for the upper limit on number of dummy cycles ? Best regards, Marek Vasut