All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: netdev@vger.kernel.org, ssujith@cisco.com, neepatel@cisco.com,
	benve@cisco.com, davem@davemloft.net, ben@decadent.org.uk,
	govindarajulu90@gmail.com, gregory.v.rose@intel.com
Subject: Re: [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet
Date: Thu, 24 Apr 2014 17:49:35 +0200	[thread overview]
Message-ID: <20140424154935.GC2864@minipsycho.orion> (raw)
In-Reply-To: <1398298956-13084-2-git-send-email-david@gibson.dropbear.id.au>

Thu, Apr 24, 2014 at 02:22:35AM CEST, david@gibson.dropbear.id.au wrote:
>Without IFLA_EXT_MASK specified, the information reported for a single
>interface in response to RTM_GETLINK is expected to fit within a netlink
>packet of NLMSG_GOODSIZE.
>
>If it doesn't, however, things will go badly wrong,  When listing all
>interfaces, netlink_dump() will incorrectly treat -EMSGSIZE on the first
>message in a packet as the end of the listing and omit information for
>that interface and all subsequent ones.  This can cause getifaddrs(3) to
>enter an infinite loop.
>
>This patch won't fix the problem, but it will WARN_ON() making it easier to
>track down what's going wrong.
>
>Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Reviewed-by: Jiri Pirko <jpirko@redhat.com>

  reply	other threads:[~2014-04-24 15:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24  0:22 [0/2] Fix problems with with IFLA_VF_PORTS (v2) David Gibson
2014-04-24  0:22 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-24 15:49   ` Jiri Pirko [this message]
2014-04-24  0:22 ` [PATCH 2/2] rtnetlink: Only supply IFLA_VF_PORTS information when RTEXT_FILTER_VF is set David Gibson
2014-04-24 15:51   ` Jiri Pirko
2014-04-24 17:53 ` [0/2] Fix problems with with IFLA_VF_PORTS (v2) David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-04-23  7:21 [0/2] Fix problems with with IFLA_VF_PORTS David Gibson
2014-04-23  7:21 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-23  9:09   ` Jiri Pirko
2014-04-23 11:41     ` David Gibson
2014-04-23 11:51       ` Jiri Pirko
2014-04-23 14:20   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424154935.GC2864@minipsycho.orion \
    --to=jiri@resnulli.us \
    --cc=ben@decadent.org.uk \
    --cc=benve@cisco.com \
    --cc=davem@davemloft.net \
    --cc=david@gibson.dropbear.id.au \
    --cc=govindarajulu90@gmail.com \
    --cc=gregory.v.rose@intel.com \
    --cc=neepatel@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssujith@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.