From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH v2 3/6] x86/P2M: simplify write_p2m_entry() Date: Thu, 24 Apr 2014 18:00:08 +0200 Message-ID: <20140424160008.GI48969@deinos.phlegethon.org> References: <53567B1C020000780000AB8C@nat28.tlf.novell.com> <53567CE8020000780000ABAB@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WdM4L-0002ZB-Df for xen-devel@lists.xenproject.org; Thu, 24 Apr 2014 16:00:13 +0000 Content-Disposition: inline In-Reply-To: <53567CE8020000780000ABAB@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Kevin Tian , Keir Fraser , suravee.suthikulpanit@amd.com, Eddie Dong , Jun Nakajima , xen-devel , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org At 13:30 +0100 on 22 Apr (1398169800), Jan Beulich wrote: > The "table_mfn" parameter really isn't needed anywhere, so it gets > dropped. > > The "struct vcpu *" one was always bogus (as was being made up by > paging_write_p2m_entry()), and is not commonly used. It can be easily > enough made up in the one place (sh_unshadow_for_p2m_change()) it is > needed, and we can otherwise pass "struct domain *" instead, properly > reflecting that P2M operations are per-domain. > > Signed-off-by: Jan Beulich Reviewed-by: Tim Deegan and I think should be applicable independent of the rest of the series. Cheers, Tim.