From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Date: Thu, 24 Apr 2014 17:50:41 +0800 Message-ID: <20140424175041.0bade2d6@xhacker> References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org To: Antoine =?UTF-8?B?VMOpbmFydA==?= Cc: "sebastian.hesselbarth@gmail.com" , "tj@kernel.org" , "alexandre.belloni@free-electrons.com" , Jimmy Xu , "linux-arm-kernel@lists.infradead.org" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-ide@vger.kernel.org Hi Antoine, On Tue, 22 Apr 2014 08:38:20 -0700 Antoine T=C3=A9nart wrote: > + /* CT timing fix */ > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | > BIT(1)); > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, > + BIT(15) | BIT(13) | BIT(12) | BIT(11) | > + BIT(10) | BIT(2) | BIT(1)); Could you please remove these code? They are not used for BG2Q, I'm sor= ry there's such mistake in the code I provided to you ;) Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbaDXJww (ORCPT ); Thu, 24 Apr 2014 05:52:52 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:10323 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754774AbaDXJws convert rfc822-to-8bit (ORCPT ); Thu, 24 Apr 2014 05:52:48 -0400 Date: Thu, 24 Apr 2014 17:50:41 +0800 From: Jisheng Zhang To: Antoine =?UTF-8?B?VMOpbmFydA==?= CC: "sebastian.hesselbarth@gmail.com" , "tj@kernel.org" , "alexandre.belloni@free-electrons.com" , Jimmy Xu , "linux-arm-kernel@lists.infradead.org" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Message-ID: <20140424175041.0bade2d6@xhacker> In-Reply-To: <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-23_04:2014-04-23,2014-04-23,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404240158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antoine, On Tue, 22 Apr 2014 08:38:20 -0700 Antoine Ténart wrote: > + /* CT timing fix */ > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | > BIT(1)); > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, > + BIT(15) | BIT(13) | BIT(12) | BIT(11) | > + BIT(10) | BIT(2) | BIT(1)); Could you please remove these code? They are not used for BG2Q, I'm sorry there's such mistake in the code I provided to you ;) Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: jszhang@marvell.com (Jisheng Zhang) Date: Thu, 24 Apr 2014 17:50:41 +0800 Subject: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs In-Reply-To: <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> References: <1398181105-19714-1-git-send-email-antoine.tenart@free-electrons.com> <1398181105-19714-2-git-send-email-antoine.tenart@free-electrons.com> Message-ID: <20140424175041.0bade2d6@xhacker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Antoine, On Tue, 22 Apr 2014 08:38:20 -0700 Antoine T?nart wrote: > + /* CT timing fix */ > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | > BIT(1)); > + ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, > + BIT(15) | BIT(13) | BIT(12) | BIT(11) | > + BIT(10) | BIT(2) | BIT(1)); Could you please remove these code? They are not used for BG2Q, I'm sorry there's such mistake in the code I provided to you ;) Thanks