From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Olivier Gay <ogay@logitech.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>,
Mathieu Meisser <mmeisser@logitech.com>
Subject: Re: [PATCH] HID: add missing hid usages
Date: Thu, 24 Apr 2014 16:26:24 -0700 [thread overview]
Message-ID: <20140424232624.GA3782@core.coreip.homeip.net> (raw)
In-Reply-To: <CAFLMSp-S9rh+i7VkX-gEdjjdrjPDZN_2=rGqLVWo=kPLBcUprw@mail.gmail.com>
On Wed, Apr 23, 2014 at 11:37:17AM +0200, Olivier Gay wrote:
> On Wed, Apr 23, 2014 at 2:04 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Mon, Apr 07, 2014 at 09:49:52AM +0200, Jiri Kosina wrote:
> >> > +#define KEY_BRIGHTNESS 0x250 /* Display Brightness */
> >
> > What is it supposed to do exactly? Show OSD for brightness?
>
> No, it's a linear control usage to (HUTTR41) "Sets brightness to a
> value between logical min and max.". I'm changing the comment to /*
> Set Brightness */.
Then it does not make sense to expose it as a key - how system should
respond to such event? Pick a random value?
If we really need to support this we need ABS_BRIGHTNESS, like we have
ABS_VOLUME.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-04-24 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 15:02 [PATCH] HID: add missing hid usages Olivier Gay
2014-04-07 7:49 ` Jiri Kosina
2014-04-14 12:22 ` Olivier Gay
2014-04-23 0:04 ` Dmitry Torokhov
2014-04-23 9:37 ` Olivier Gay
2014-04-24 23:26 ` Dmitry Torokhov [this message]
2014-04-25 8:10 ` Olivier Gay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424232624.GA3782@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=mmeisser@logitech.com \
--cc=nlopezcasad@logitech.com \
--cc=ogay@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.