From: Mark Brown <broonie@kernel.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, jarkko.nikula@linux.intel.com,
bardliao@realtek.com, flove@realtek.com
Subject: Re: [PATCH v2] ASoC: rt5640: Add minimal support for RT5642
Date: Sat, 26 Apr 2014 01:22:34 +0100 [thread overview]
Message-ID: <20140426002234.GS12304@sirena.org.uk> (raw)
In-Reply-To: <535ADCD2.8050804@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 1137 bytes --]
On Fri, Apr 25, 2014 at 04:08:18PM -0600, Stephen Warren wrote:
> On 04/16/2014 08:24 PM, bardliao@realtek.com wrote:
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Is this derived from Jarkko's patch? If so, shouldn't he be listed as
> the author, not you? If it wasn't, then presumably his S-o-b line
> shouldn't be in the patch description.
It was derived but edited; I did check with Jarkko that he was OK before
applying.
> I can see why this patch causes the driver to support the wrong chip.
> However, I can't imagine why that causes all the log spew at startup.
> Perhaps the driver is just broken on RT5639 at present (although I don't
> recall seeing any issues when booting on a board that actually had
> one...) Is part of the driver keying off this now incorrect ID register
> read, yet some other part of the driver registering widgets/routes based
> on which entry matched in struct i2c_device_id rt5640_i2c_id, hence
> they're falling out of sync due to this change? If so, that seems like
> another bug that needs fixing.
I'd be surprised if it weren't the latter. Either way it needs fixing.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-26 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 2:24 [PATCH v2] ASoC: rt5640: Add minimal support for RT5642 bardliao
2014-04-17 19:01 ` Mark Brown
2014-04-22 6:01 ` Jarkko Nikula
2014-04-22 11:53 ` Mark Brown
2014-04-22 14:14 ` Oder
2014-04-22 17:12 ` Mark Brown
2014-04-25 22:08 ` Stephen Warren
2014-04-26 0:22 ` Mark Brown [this message]
2014-04-28 6:47 ` Jarkko Nikula
2014-04-27 14:57 ` [PATCH v2] ASoC: rt5640: Add minimal supportforRT5642 Bard Liao
2014-04-28 8:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140426002234.GS12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.