Re: [PATCH] ASoC: mc13783: Add devicetree support

[Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

> > > > > > > > > > This patch adds devicetree support for mc13783-codec.
> > > > > > > > > 
> > > > > > > > > Applied, thanks.
> > > > > > > > 
> > > > > > > > No Mark, no!
> > > > > > > 
> > > > > > > What a problem, Lee?
> > > > > > 
> > > > > > There's no problem with the patch, don't worry.
> > > > > > 
> > > > > > Neither Mark, nor I can apply this patch independently, we need to
> > > > > > create a shared branch somewhere, or we'll risk conflicts at merge
> > > > > > time.
> > > > > 
> > > > > I can separate this patch for ASoC and MFD if need.
> > > > > But this will work only if both is applied.
> > > > 
> > > > Are there build dependencies, or only functional ones?
> > > 
> > > Functional only.
> > > At this time "fsl,mc13xxx-uses-codec" option for PMIC produce a kernel crash :)
> > 
> > If patches can be broken up notwithstanding build errors, they should
> > be.  It makes things sooo much easier.
> 
> In fact that the patch for MFD is not obvious if the codec have no DT support...
> 
> If you do we see this problem (pdata == NULL and we pass this to the
> driver in DT case), for me it not worst to separate this. What we do?
> Should this be a two patches in one series or one for MFD and one for ASoC then?

You can put them into a patch-set and I will take the MFD one, Mark
will take the other.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html