From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759646AbaD3XiJ (ORCPT ); Wed, 30 Apr 2014 19:38:09 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:49605 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754512AbaD3XiI (ORCPT ); Wed, 30 Apr 2014 19:38:08 -0400 Date: Thu, 1 May 2014 00:38:06 +0100 From: Al Viro To: Linus Torvalds Cc: Miklos Szeredi , Dave Chinner , Linux Kernel Mailing List , linux-fsdevel Subject: Re: dcache shrink list corruption? Message-ID: <20140430233805.GW18016@ZenIV.linux.org.uk> References: <20140430183650.GQ18016@ZenIV.linux.org.uk> <20140430190227.GR18016@ZenIV.linux.org.uk> <20140430195918.GS18016@ZenIV.linux.org.uk> <20140430203823.GT18016@ZenIV.linux.org.uk> <20140430211206.GU18016@ZenIV.linux.org.uk> <20140430221238.GV18016@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 30, 2014 at 04:04:58PM -0700, Linus Torvalds wrote: > On Wed, Apr 30, 2014 at 3:12 PM, Al Viro wrote: > > > > I've just pushed the whole thing to vfs.git#for-linus; > > review and testing would be very welcome. > > I have no half-way relevant test-case for this, so I'm hoping people > who have good VFS stress-tests (preferably under memory pressure so > that we get that whole shrinking path) will test. > > But it looks fine. > > That said, I do hate that RCU read-lock around the final spin-unlock. So do I, obviously... After looking through the rest of arch_spin_unlock(), it looks like the only suspicious one except the paravirt on x86 is blackfin. And that might be misreading - I'm not familiar enough with the architecture to tell...