From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754558AbaEAJm7 (ORCPT ); Thu, 1 May 2014 05:42:59 -0400 Received: from mail-ee0-f52.google.com ([74.125.83.52]:65236 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbaEAJm5 (ORCPT ); Thu, 1 May 2014 05:42:57 -0400 Date: Thu, 1 May 2014 11:42:52 +0200 From: Miklos Szeredi To: Al Viro Cc: Linus Torvalds , Dave Chinner , Linux Kernel Mailing List , linux-fsdevel Subject: Re: dcache shrink list corruption? Message-ID: <20140501094252.GE3113@tucsk.piliscsaba.szeredi.hu> References: <20140430211206.GU18016@ZenIV.linux.org.uk> <20140430221238.GV18016@ZenIV.linux.org.uk> <20140430234341.GX18016@ZenIV.linux.org.uk> <20140501025105.GY18016@ZenIV.linux.org.uk> <20140501031251.GZ18016@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140501031251.GZ18016@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Two points about latest version (dentry_kill-2): - Doing anything with dentry->d_parent in case of DCACHE_DENTRY_KILLED looks seriously wrong. Parent has been dealt with, at that point, by the other caller, no? - "bool foo = flag & FLAG" looks suspicious. Is this guaranteed not to overflow? Thanks, Miklos