From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhL5U-0006Cq-9p for qemu-devel@nongnu.org; Mon, 05 May 2014 11:45:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhL5P-0003qb-4y for qemu-devel@nongnu.org; Mon, 05 May 2014 11:45:52 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:43027 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhL5O-0003kL-SQ for qemu-devel@nongnu.org; Mon, 05 May 2014 11:45:47 -0400 Date: Mon, 5 May 2014 17:46:12 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140505154612.GA19577@irqsave.net> References: <1398956086-20171-1-git-send-email-stefanha@redhat.com> <1398956086-20171-13-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1398956086-20171-13-git-send-email-stefanha@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 12/22] quorum: implement .bdrv_detach/attach_aio_context() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , =?iso-8859-1?Q?Beno=EEt?= Canet , "Shergill, Gurinder" , qemu-devel@nongnu.org, Paolo Bonzini , "Vinod, Chegu" The Thursday 01 May 2014 =E0 16:54:36 (+0200), Stefan Hajnoczi wrote : > Implement .bdrv_detach/attach_aio_context() interfaces to propagate > detach/attach to BDRVQuorumState->bs[] children. The block layer takes > care of ->file and ->backing_hd but doesn't know about our ->bs[] > BlockDriverStates, which is also part of the graph. >=20 > Cc: Beno=EEt Canet > Signed-off-by: Stefan Hajnoczi > --- > block/quorum.c | 48 ++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 36 insertions(+), 12 deletions(-) >=20 > diff --git a/block/quorum.c b/block/quorum.c > index ecec3a5..426077a 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -848,25 +848,49 @@ static void quorum_close(BlockDriverState *bs) > g_free(s->bs); > } > =20 > +static void quorum_detach_aio_context(BlockDriverState *bs) > +{ > + BDRVQuorumState *s =3D bs->opaque; > + int i; > + > + for (i =3D 0; i < s->num_children; i++) { > + bdrv_detach_aio_context(s->bs[i]); > + } > +} > + > +static void quorum_attach_aio_context(BlockDriverState *bs, > + AioContext *new_context) > +{ > + BDRVQuorumState *s =3D bs->opaque; > + int i; > + > + for (i =3D 0; i < s->num_children; i++) { > + bdrv_attach_aio_context(s->bs[i], new_context); > + } > +} > + > static BlockDriver bdrv_quorum =3D { > - .format_name =3D "quorum", > - .protocol_name =3D "quorum", > + .format_name =3D "quorum", > + .protocol_name =3D "quorum", > + > + .instance_size =3D sizeof(BDRVQuorumState), > =20 > - .instance_size =3D sizeof(BDRVQuorumState), > + .bdrv_file_open =3D quorum_open, > + .bdrv_close =3D quorum_close, > =20 > - .bdrv_file_open =3D quorum_open, > - .bdrv_close =3D quorum_close, > + .bdrv_co_flush_to_disk =3D quorum_co_flush, > =20 > - .bdrv_co_flush_to_disk =3D quorum_co_flush, > + .bdrv_getlength =3D quorum_getlength, > =20 > - .bdrv_getlength =3D quorum_getlength, > + .bdrv_aio_readv =3D quorum_aio_readv, > + .bdrv_aio_writev =3D quorum_aio_writev, > + .bdrv_invalidate_cache =3D quorum_invalidate_cache, > =20 > - .bdrv_aio_readv =3D quorum_aio_readv, > - .bdrv_aio_writev =3D quorum_aio_writev, > - .bdrv_invalidate_cache =3D quorum_invalidate_cache, > + .bdrv_detach_aio_context =3D quorum_detach_aio_context, > + .bdrv_attach_aio_context =3D quorum_attach_aio_context, > =20 > - .is_filter =3D true, > - .bdrv_recurse_is_first_non_filter =3D quorum_recurse_is_first_non_= filter, > + .is_filter =3D true, > + .bdrv_recurse_is_first_non_filter =3D quorum_recurse_is_first_no= n_filter, > }; > =20 > static void bdrv_quorum_init(void) > --=20 > 1.9.0 >=20 Look good Reviewed-by: Benoit Canet